Skip to content

Comments

libtensorflow: 2.13.0 -> 2.14.0#272838

Open
zeuner wants to merge 4 commits intoNixOS:masterfrom
zeuner:tensorflow-2-14
Open

libtensorflow: 2.13.0 -> 2.14.0#272838
zeuner wants to merge 4 commits intoNixOS:masterfrom
zeuner:tensorflow-2-14

Conversation

@zeuner
Copy link
Contributor

@zeuner zeuner commented Dec 8, 2023

Description of changes

Updated the version and adapted scripts and patches to make it build. Basic tests also succeeded. There remains a warning about ml_dtypes, which might be expected (see #258546 (comment))

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Dec 8, 2023
@zeuner zeuner mentioned this pull request Dec 8, 2023
Closed
13 tasks
@GaetanLepage
Copy link
Contributor

GaetanLepage commented Dec 8, 2023

Thank you for this work @zeuner !
About ml_dtypes, maybe you could directly go for 2.15.0 ?

@zeuner zeuner force-pushed the tensorflow-2-14 branch 2 times, most recently from f2ee916 to ae92fdd Compare December 8, 2023 10:52
@zeuner
Copy link
Contributor Author

zeuner commented Dec 8, 2023

About ml_dtypes, maybe you could directly go for 2.15.0 ?

In the process of doing so. When I saw 2.15.0, I had already started working on 2.14.0, so I decided to finish it first in order to get all the clang-related changes right. Hope to get it adapted to 2.15.0, soon.

@GaetanLepage
Copy link
Contributor

GaetanLepage commented Dec 8, 2023

In the process of doing so. When I saw 2.15.0, I had already started working on 2.14.0, so I decided to finish it first in order to get all the clang-related changes right. Hope to get it adapted to 2.15.0, soon.

Very cool !

@ofborg ofborg bot requested a review from abbradar December 8, 2023 12:48
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Dec 8, 2023
@zeuner zeuner force-pushed the tensorflow-2-14 branch 3 times, most recently from 42cfe4d to fa0d054 Compare December 10, 2023 12:53
@zeuner zeuner marked this pull request as draft December 11, 2023 21:51
@zeuner zeuner force-pushed the tensorflow-2-14 branch 7 times, most recently from bb38de2 to d50895a Compare December 17, 2023 01:59
@zeuner zeuner force-pushed the tensorflow-2-14 branch 3 times, most recently from 0a53960 to 5b66a10 Compare December 25, 2023 13:33
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Dec 28, 2023
@zeuner zeuner mentioned this pull request Jan 4, 2024
Open
13 tasks
@zeuner
Copy link
Contributor Author

zeuner commented Nov 10, 2024

  • python311Packages.shimmy

These confuse me a bit. AFAICS, python3Packages.shimmy does not depend on python3Packages.tensorflow or python3Packages.keras (the packages being touched by this PR), so I'm not sure what I could do about it. Am I missing something here?

I could also build it here on with this PR merged.

@zeuner zeuner force-pushed the tensorflow-2-14 branch 2 times, most recently from ee5c89d to 0bd2b4f Compare November 17, 2024 22:14
@zeuner
Copy link
Contributor Author

zeuner commented Nov 17, 2024

Figured out that pypi_psutil led to the deps hashes being unstable on aarch64-linux. They need to be recomputed now, but should hopefully be stable afterwards.

@FliegendeWurst
Copy link
Member

FliegendeWurst commented Nov 25, 2024

ofborg reports the hash to be sha256-KXSbqwZpN4Im32St0ADyIc4N5/SQfiQPDoLu9bXbckY=.

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Nov 26, 2024
@FliegendeWurst FliegendeWurst added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 4, 2024
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 16, 2024
@zeuner zeuner force-pushed the tensorflow-2-14 branch 2 times, most recently from f56ffff to be2f4e9 Compare January 2, 2025 20:44
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 4, 2025
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 12, 2025
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 15, 2025
@nixpkgs-ci nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 11, 2025
@zeuner
Copy link
Contributor Author

zeuner commented Sep 21, 2025

The CI might require merging #437407 before.

@nixpkgs-ci nixpkgs-ci bot added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md labels Sep 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samuela samuela samuela left review comments

@SomeoneSerge SomeoneSerge SomeoneSerge left review comments

@GaetanLepage GaetanLepage GaetanLepage left review comments

@abbradar abbradar Awaiting requested review from abbradar

@natsukium natsukium Awaiting requested review from natsukium

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@zeuner @GaetanLepage @viraptor @boltzmannrain @FliegendeWurst @samuela @SomeoneSerge @wegank