Skip to content

ci/eval/compare: avoid CI failures on non-github maintainer records #437407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zeuner wants to merge 1 commit into from
Closed

ci/eval/compare: avoid CI failures on non-github maintainer records #437407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions ci/eval/compare/maintainers.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,14 +95,20 @@ let

attrsWithModifiedFiles = builtins.filter (pkg: anyMatchingFiles pkg.filenames) attrsWithFilenames;

# TODO: create ping lists for other contacts once non-GitHub ping
# implementations get merged
Comment on lines +98 to +99
Copy link
Contributor

@wolfgangwalther wolfgangwalther Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't accept this TODO.

listToPing = lib.concatMap (
pkg:
builtins.map (maintainer: {
id = maintainer.githubId;
inherit (maintainer) github;
packageName = pkg.name;
dueToFiles = pkg.filenames;
}) pkg.maintainers
builtins.map
(maintainer: {
id = maintainer.githubId;
inherit (maintainer) github;
packageName = pkg.name;
dueToFiles = pkg.filenames;
})
# TODO: If community consensus (e.g. an RFC) makes `githubId` mandatory,
# simplify to `pkg.maintainers`
Comment on lines +109 to +110
Copy link
Contributor

@wolfgangwalther wolfgangwalther Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Community consensus is already reached, this is just about getting the implementation merged, so I won't accept this TODO either.

(builtins.filter (maintainer: maintainer ? githubId) pkg.maintainers)
) attrsWithModifiedFiles;

byMaintainer = lib.groupBy (ping: toString ping.${if byName then "github" else "id"}) listToPing;
Expand Down
Loading