Skip to content

Comments

luci-go: 0-unstable-2024-10-31 -> 0-unstable-2025-08-26#437389

Closed
zeuner wants to merge 1 commit intoNixOS:masterfrom
zeuner:luci-go-0-unstable-2025-08-26
Closed

luci-go: 0-unstable-2024-10-31 -> 0-unstable-2025-08-26#437389
zeuner wants to merge 1 commit intoNixOS:masterfrom
zeuner:luci-go-0-unstable-2025-08-26

Conversation

@zeuner
Copy link
Contributor

@zeuner zeuner commented Aug 27, 2025

Bumped to a new commit. @wolfgangwalther seems to urgently need an upgrade, and requested it off-band. Please check whether it suits you.

Closes #437435

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@zeuner
Copy link
Contributor Author

zeuner commented Aug 27, 2025

Merging #437407 before should fix the CI issue.

@zeuner zeuner mentioned this pull request Aug 27, 2025
1 task
@wolfgangwalther
Copy link
Contributor

See #437082 (comment). I think it makes more sense to drop the package, if it's only intended to be used as a dependency, but no other package depends on it. It could be re-introduced together with the first package using it.

@wolfgangwalther wolfgangwalther mentioned this pull request Aug 27, 2025
1 task
@zeuner
Copy link
Contributor Author

zeuner commented Aug 27, 2025

See #437082 (comment). I think it makes more sense to drop the package, if it's only intended to be used as a dependency, but no other package depends on it. It could be re-introduced together with the first package using it.

I already pushed it because I assumed that being already in the repo would lead to build failures being detected early, thus the dependency being ready for git master when other packages follow.

Seems like I was wrong, as found by #437082 (comment)

Still, I think it's better to fix the infrastructure so maintainers get notified of build failures, rather than dropping the package. It contains cipd, which seems to be pulled as a binary blob by nixpkgs currently due to the perceived lack of a nixpkgs build. Thus clarifying the description in the hope the usefulness gets more obvious.

@zeuner zeuner force-pushed the luci-go-0-unstable-2025-08-26 branch from 9152c2a to a3174f3 Compare August 27, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants