pkgs/README: Document commit prefixes & automatic CI builds#431688
pkgs/README: Document commit prefixes & automatic CI builds#431688wolfgangwalther merged 1 commit intoNixOS:masterfrom
Conversation
wolfgangwalther
left a comment
There was a problem hiding this comment.
These guidelines are specific to pkgs/ - they don't apply to all the other parts of nixpkgs. Thus, I think the right place to put them is in the specific conventions for this subfolder at https://github.com/NixOS/nixpkgs/tree/master/pkgs#commit-conventions.
4245d3c to
d74f425
Compare
pkgs/README.md
Outdated
There was a problem hiding this comment.
Note the following:
nix-repl> python3Packages.recurseForDerivations
false
nix-repl> python312Packages.recurseForDerivations
true
nix-repl> python313Packages.recurseForDerivations
true
So this explanation doesn't quite line up, yet.
There was a problem hiding this comment.
Hmm this is indeed confusing. The ofborg README also doesn't give as examples python3Packages, but here's an example were ofborg created (as always) a PR with python3Packages in the prefix and ofborg did (at least attempted) to build the packages:
See also:
Let's ask @Artturin for help specifically on this.
There was a problem hiding this comment.
aliases like python3Packages.foobar didn't use to work before the ofborg migration necessitating e.g. python313Packages.foobar, but now it does. More context in NixOS/ofborg#577. Since that issue was closed r-ryantm was switched to the python3Packages alias which avoids a lot of duplicate PRs.
There was a problem hiding this comment.
Thanks @pbsds for commenting. I sort of figured that out, but it's nice to link that issue too. The questions making this review conversation still open, are: What is the parameter that dictates if ofborg will build an attribute or not? Is it whether they are recursed to or not and python3Packages is an exception hard-coded in ofborg's code? Or is it due to something more subtle the way we define these attribute sets in all-packages.nix?
There was a problem hiding this comment.
I think by now ofborg just builds what it gets. You tell it to build a.b.c: init and it will build a.b.c, no questions asked. That's because it doesn't do any eval step anymore, that could do any of the recursion parts.
There was a problem hiding this comment.
It might be true nowadays indeed. Let's wait and see:
There was a problem hiding this comment.
Indeed ofborg has no difference between python3.pkgs and python3Packages and the rest! I tested also a gotify-server.ui: commit, where gotify-server.ui is completely not recursed into by Hydra, and it built it too.
There was a problem hiding this comment.
The python docs seem to give outdated advice on this python3Packages thing:
nixpkgs/doc/languages-frameworks/python.section.md
Lines 2127 to 2131 in daa2ab8
I guess we should update these, too.
There was a problem hiding this comment.
Thanks for noticing that too @wolfgangwalther . PR is at:
d74f425 to
39c2a4a
Compare
hard blockers had been addressed, although some questions still remain.
39c2a4a to
626b9a6
Compare
|
Thanks for your reviews, the whole |
2f65f9e to
34fd7b9
Compare
34fd7b9 to
c41ee2b
Compare
Somewhat based upon ofborg's README contents: https://github.com/NixOS/ofborg?tab=readme-ov-file#automatic-building Co-authored-by: Wolfgang Walther <walther@technowledgy.de> Co-authored-by: Peder Bergebakken Sundt <pbsds@hotmail.com>
c41ee2b to
6857dc8
Compare
|
Since this describes what is already fact and is "just" an updated documentation of what is available in the ofborg repo, I consider this uncontroversial enough in principle to not wait for more community feedback. |
|
Please ignore my previous comment. |
I found myself explaining these details very often through out my time with Nixpkgs, and it always felt a bit weird for me that these are document in a different repository. So I decided to slightly copy that content to Nixpkgs, with a refresh set of examples.
I'm asking for a review from a few people who were involved in #400934, as this PR should be tangent but still may be slightly related: