ocrfeeder: Add standard-imghdr to ocrfeeder dependencies#480779
ocrfeeder: Add standard-imghdr to ocrfeeder dependencies#4807792hexed wants to merge 2 commits intoNixOS:masterfrom
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
nixpkgs-ci
bot
added
the
12.approvals: 1
| ] | ||
| )) | ||
| ]; | ||
|
|
There was a problem hiding this comment.
Please remove this unneeded newline.
There was a problem hiding this comment.
The newline is nice to have for readability, unsure why it wasn't there in the first place
There was a problem hiding this comment.
The newline is nice to have for readability, unsure why it wasn't there in the first place
It is arguable, and even if this was very convincing, it would have been more correct to make readability changes in a separate commit.
There was a problem hiding this comment.
Sounds good, I'll make another commit for this!
There was a problem hiding this comment.
Sounds good, I'll make another commit for this!
I really prefer you won't :) unless you will make substantial other readability improvements. TBH I don't understand why people care all that much about newlines. If you were more involved with this expression in general I wouldn't have mind, but otherwise I prefer not 🙏 .
There was a problem hiding this comment.
its alright its just a single newline insertion, i don't think it'll matter much anyway
There was a problem hiding this comment.
It seems pretty insane to insist on that new line, especially if you agree with making a separate commit for that. Since (noticed only now) the commits also have the bad prefix - nixpkgs/ocrfeeder instead of ocrfeeder, I will merge the key change suggested here elsewhere:
There was a problem hiding this comment.
its really not insane and the prefix is also acceptable, if anything, it only helps understanding where we're merging the PR, you may have a look at other PRs if you're unsure
There was a problem hiding this comment.
its really not insane and the prefix is also acceptable, if anything, it only helps understanding where we're merging the PR, you may have a look at other PRs if you're unsure
As for the commits separation, newlines and readability, Nixpkgs doesn't have concrete rules written unfortunately, but that is a WIP - see #400934 . As for the commit prefix, there is no debate, see #431688 .
This seems to be the required dependency. Without it the program fails to open and errors out with imghdr not found.
doronbehar
changed the title
3 participants
This seems to be the required dependency. Without it the program fails to open and errors out with imghdr not found.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.