all-packages.nix: pythonXPackages point to pythonXXPackages#165994
Merged
Artturin merged 1 commit intoNixOS:masterfrom Mar 28, 2022
Merged
all-packages.nix: pythonXPackages point to pythonXXPackages#165994Artturin merged 1 commit intoNixOS:masterfrom
Artturin merged 1 commit intoNixOS:masterfrom
Conversation
Member
Author
|
looks like it used to be pythonXPackages but was switched to python3.pkgs in 66f7398 |
Member
Author
|
it shows that this will have many rebuilds, however this will have 0 rebuilds it can be confirmed with nix eval ".#python3Packages.aadict.drvPath" && git apply - <<< $(curl -s https://patch-diff.githubusercontent.com/raw/NixOS/nixpkgs/pull/165994.patch) && nix eval ".#python3Packages.aadict.drvPath" |
Member
|
Can you fix up the commit message? The first line looks messy and probably shouldn't repeat the diff but instead describe the change. Something along the lines of |
99b198d to
3b33b1f
Compare
Member
|
Will not recursing into these attrsets still mean they will be built by hydra? |
Member
Author
python39Packages is recursed in to later |
instead of pythonXX.pkgs should help with ofborg not building commits which have `python3Packages` instead of `python39Packages` see NixOS/ofborg#577 dontRecurseIntoAttrs is used to avoid a performance penalty
3b33b1f to
6e6a320
Compare
13 tasks
Member
|
This should be active immediately? Lets see if it works. Sticking to python310Packages for now. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instead of pythonXX.pkgs
should help with ofborg not building
commits which have
python3Packagesinstead ofpython39Packagessee NixOS/ofborg#577
dontRecurseIntoAttrs is used to avoid a performance penalty
@SuperSandro2000 you'll probably be interested in this
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes