Skip to content

storage3: fix typo#430804

Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom
Siegema:fix-storage3-typo
Aug 13, 2025
Merged

storage3: fix typo#430804
wolfgangwalther merged 1 commit intoNixOS:masterfrom
Siegema:fix-storage3-typo

Conversation

@Siegema
Copy link
Contributor

@Siegema Siegema commented Aug 4, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 6.topic: python Python is a high-level, general-purpose programming language. labels Aug 4, 2025
@Siegema Siegema mentioned this pull request Aug 4, 2025
Merged
13 tasks
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Aug 4, 2025
@eclairevoyant
Copy link
Contributor

eclairevoyant commented Aug 4, 2025 •
edited
Loading

Btw I believe the commit format should be python313Packages.storage3: fix typo for CI to pick it up properly

@Siegema Siegema force-pushed the fix-storage3-typo branch from d45016c to d4e4b7d Compare August 4, 2025 03:14
@Siegema
Copy link
Contributor Author

Siegema commented Aug 4, 2025

Btw I believe the commit format should be python313Packages.storage3: fix typo for CI to pick it up properly

Yea, agreed changing the commit name. Think it's fine with python3packages though.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Aug 4, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Aug 4, 2025
@eclairevoyant
Copy link
Contributor

eclairevoyant commented Aug 5, 2025

Btw I believe the commit format should be python313Packages.storage3: fix typo for CI to pick it up properly

Yea, agreed changing the commit name. Think it's fine with python3packages though.

nixpkgs/doc/languages-frameworks/python.section.md

Lines 2127 to 2130 in 97f1007

* The current default version of python should be included
in commit messages to enable automatic builds by ofborg.
For example `python313Packages.numpy: 1.11 -> 1.12` should be used rather
than `python3Packages.numpy: 1.11 -> 1.12`.

We don't use ofborg anymore afaik but python3Packages is an alias not an actual attribute in pkgs.

@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented Aug 13, 2025

We do use ofborg to build, but that information is outdated as tests have shown in #431688 (comment). TLDR: You can use python3Packages just fine.

@wolfgangwalther wolfgangwalther merged commit daa2ab8 into NixOS:master Aug 13, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sigmanificient Sigmanificient Sigmanificient approved these changes

+1 more reviewer

@eclairevoyant eclairevoyant eclairevoyant approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Siegema @eclairevoyant @wolfgangwalther @Sigmanificient