Skip to content

python3Packages.accelerate: disable tests that fail on Darwin#422747

Merged
GaetanLepage merged 2 commits intoNixOS:masterfrom
sarahec:accelerate-port-conflict-darwin
Jul 6, 2025
Merged

python3Packages.accelerate: disable tests that fail on Darwin#422747
GaetanLepage merged 2 commits intoNixOS:masterfrom
sarahec:accelerate-port-conflict-darwin

Conversation

@sarahec
Copy link
Contributor

@sarahec sarahec commented Jul 5, 2025 •
edited
Loading

  1. Checking test_config_compatibility causes a port conflict on Darwin. This happens during nixpkgs-review when it tries building Python 3.12 and 3.13 versions simultaneously and encounters the lack of network namespaces on Darwin. Disabled test on Darwin only.
  2. Two other tests fail with torch._inductor.exc.InductorError: TypeError: cannot determine truth value of Relational. Disabled on Darwin only.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@sarahec
Copy link
Contributor Author

sarahec commented Jul 5, 2025

Discovered in nixpkgs-review of #420628

@sarahec
python3Packages.accelerate: disable test that fails in nixpkgs-review
f797415 
Testing test_config_compatibility in two pythons simultaneously causes a port conflict on Darwin.
@sarahec sarahec force-pushed the accelerate-port-conflict-darwin branch from 81ce20a to f797415 Compare July 5, 2025 17:43
@nixpkgs-ci nixpkgs-ci bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 5, 2025
@nix-owners nix-owners bot requested a review from bcdarwin July 5, 2025 17:50
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 5, 2025
@sarahec sarahec requested a review from GaetanLepage July 6, 2025 01:53
@sarahec sarahec changed the title python3Packages.accelerate: disable test that fails in nixpkgs-review python3Packages.accelerate: disable tests that fail on Darwin Jul 6, 2025
This was referenced Jul 6, 2025
Merged
Merged
Merged
@sarahec
Copy link
Contributor Author

sarahec commented Jul 6, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 422747
Commit: 9aefb6795023ebcf6f863f28da3d15862ca983a9

aarch64-darwin

❌ 27 packages failed to build:
  • aider-chat-full
  • aider-chat-full.dist
  • aider-chat-with-help
  • aider-chat-with-help.dist
  • python312Packages.langchain-huggingface
  • python312Packages.langchain-huggingface.dist
  • python312Packages.llama-index-embeddings-huggingface
  • python312Packages.llama-index-embeddings-huggingface.dist
  • python312Packages.llm-sentence-transformers
  • python312Packages.llm-sentence-transformers.dist
  • python312Packages.manifest-ml
  • python312Packages.manifest-ml.dist
  • python312Packages.sentence-transformers
  • python312Packages.sentence-transformers.dist
  • python313Packages.langchain-huggingface
  • python313Packages.langchain-huggingface.dist
  • python313Packages.llama-index-embeddings-huggingface
  • python313Packages.llama-index-embeddings-huggingface.dist
  • python313Packages.llm-sentence-transformers
  • python313Packages.llm-sentence-transformers.dist
  • python313Packages.manifest-ml
  • python313Packages.manifest-ml.dist
  • python313Packages.sentence-transformers
  • python313Packages.sentence-transformers.dist
  • vectorcode
  • vectorcode.dist
  • vimPlugins.vectorcode-nvim
✅ 54 packages built:
  • docling (python313Packages.docling)
  • docling-serve (python313Packages.docling-serve)
  • docling-serve.dist (python313Packages.docling-serve.dist)
  • docling.dist (python313Packages.docling.dist)
  • libretranslate (python313Packages.libretranslate)
  • libretranslate.dist (python313Packages.libretranslate.dist)
  • python312Packages.accelerate
  • python312Packages.accelerate.dist
  • python312Packages.argos-translate-files
  • python312Packages.argos-translate-files.dist
  • python312Packages.argostranslate
  • python312Packages.argostranslate.dist
  • python312Packages.docling
  • python312Packages.docling-serve
  • python312Packages.docling-serve.dist
  • python312Packages.docling.dist
  • python312Packages.k-diffusion
  • python312Packages.k-diffusion.dist
  • python312Packages.libretranslate
  • python312Packages.libretranslate.dist
  • python312Packages.lm-eval
  • python312Packages.lm-eval.dist
  • python312Packages.peacasso
  • python312Packages.peacasso.dist
  • python312Packages.peft
  • python312Packages.peft.dist
  • python312Packages.smolagents
  • python312Packages.smolagents.dist
  • python312Packages.stanza
  • python312Packages.stanza.dist
  • python312Packages.translatehtml
  • python312Packages.translatehtml.dist
  • python312Packages.trl
  • python312Packages.trl.dist
  • python313Packages.accelerate
  • python313Packages.accelerate.dist
  • python313Packages.argos-translate-files
  • python313Packages.argos-translate-files.dist
  • python313Packages.argostranslate
  • python313Packages.argostranslate.dist
  • python313Packages.k-diffusion
  • python313Packages.k-diffusion.dist
  • python313Packages.peacasso
  • python313Packages.peacasso.dist
  • python313Packages.peft
  • python313Packages.peft.dist
  • python313Packages.smolagents
  • python313Packages.smolagents.dist
  • python313Packages.stanza
  • python313Packages.stanza.dist
  • python313Packages.translatehtml
  • python313Packages.translatehtml.dist
  • python313Packages.trl
  • python313Packages.trl.dist
Error logs: `aarch64-darwin`
python312Packages.sentence-transformers 
configfile: pyproject.toml
testpaths: tests
plugins: cov-nixpkgs-stub-1.0.0, hypothesis-6.131.17
collecting ... 
collected 508 items / 449 deselected / 1 skipped / 59 selected                 

tests/cross_encoder/test_deprecated_imports.py ......                    [ 10%]

tests/evaluation/test_binary_classification_evaluator.py ..              [ 13%]

tests/models/test_router.py ...........                                  [ 32%]

tests/models/test_static_embedding.py ss                                 [ 35%]

tests/samplers/test_group_by_label_batch_sampler.py ...                  [ 40%]

tests/samplers/test_no_duplicates_batch_sampler.py ...                   [ 45%]

tests/samplers/test_round_robin_batch_sampler.py ..                      [ 49%]

tests/test_cmnrl.py ..                                                   [ 52%]

tests/test_sparse_tensor.py ..Fatal Python error: Segmentation fault


Thread 0x0000000367b1f000 (most recent call first):

Fatal Python error: Segmentation fault


File /nix/store/0znljckc2qhpsjs033wjc07xzqiysp3g-pytest-check-hook/nix-support/setup-hook: line 23:  3935 Segmentation fault: 11  /nix/store/q54d9qqlb27g2nf9ja4zsa89gl7b3yvm-python3-3.12.11/bin/python3.12 "${flagsArray[@]}"

python313Packages.sentence-transformers 
tests/cross_encoder/test_deprecated_imports.py ......                    [ 10%]
tests/evaluation/test_binary_classification_evaluator.py ..              [ 13%]
tests/models/test_router.py ...........                                  [ 32%]
tests/models/test_static_embedding.py ss                                 [ 35%]
tests/samplers/test_group_by_label_batch_sampler.py ...                  [ 40%]
tests/samplers/test_no_duplicates_batch_sampler.py ...                   [ 45%]
tests/samplers/test_round_robin_batch_sampler.py ..                      [ 49%]
tests/test_cmnrl.py ..                                                   [ 52%]
tests/test_sparse_tensor.py ..Fatal Python error: Segmentation fault

Thread 0x0000000368d1f000 (most recent call first):

File "/nix/store/j1spz18w5a10r9nj4wpkyh0cx730rs4z-python3-3.13.4/lib/python3.13/threading.py", line 363 in wait

File "/nix/store/j1spz18w5a10r9nj4wpkyh0cx730rs4z-python3-3.13.4/lib/python3.13/threading.py", line 659 in wait

File "/nix/store/l8xv8gwwsp628xdqxy3h4fyjhxsfr0bm-python3.13-tqdm-4.67.1/lib/python3.13/site-packages/tqdm/_monitor.py", line 60 in run

File "/nix/store/j1spz18w5a10r9nj4wpkyh0cx730rs4z-python3-3.13.4/lib/python3.13/threading.py", line 1043 in _bootstrap_inner

File "/nix/store/j1spz18w5a10r9nj4wpkyh0cx730rs4z-python3-3.13.4/lib/python3.13/threading.py", line 1014 in _bootstrap


Thread 0x00000002036bdf00 (most recent call first):

File /nix/store/w2k4627hj4xfsz1kwh3bxblv425yw726-pytest-check-hook/nix-support/setup-hook: line 23: 11004 Segmentation fault: 11  /nix/store/j1spz18w5a10r9nj4wpkyh0cx730rs4z-python3-3.13.4/bin/python3.13 "${flagsArray[@]}"

@sarahec
Copy link
Contributor Author

sarahec commented Jul 6, 2025 •
edited
Loading

@GaetanLepage this one next, please. Build failures are due to python3Packages.sentence-transformers having a broken test (fixed in #422742); this has to be merged before '742.

@GaetanLepage
Copy link
Contributor

GaetanLepage commented Jul 6, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 422747
Commit: 9aefb6795023ebcf6f863f28da3d15862ca983a9

x86_64-darwin

✅ 81 packages built:
  • aider-chat-full
  • aider-chat-full.dist
  • aider-chat-with-help
  • aider-chat-with-help.dist
  • docling (python313Packages.docling)
  • docling-serve (python313Packages.docling-serve)
  • docling-serve.dist (python313Packages.docling-serve.dist)
  • docling.dist (python313Packages.docling.dist)
  • libretranslate (python313Packages.libretranslate)
  • libretranslate.dist (python313Packages.libretranslate.dist)
  • python312Packages.accelerate
  • python312Packages.accelerate.dist
  • python312Packages.argos-translate-files
  • python312Packages.argos-translate-files.dist
  • python312Packages.argostranslate
  • python312Packages.argostranslate.dist
  • python312Packages.docling
  • python312Packages.docling-serve
  • python312Packages.docling-serve.dist
  • python312Packages.docling.dist
  • python312Packages.k-diffusion
  • python312Packages.k-diffusion.dist
  • python312Packages.langchain-huggingface
  • python312Packages.langchain-huggingface.dist
  • python312Packages.libretranslate
  • python312Packages.libretranslate.dist
  • python312Packages.llama-index-embeddings-huggingface
  • python312Packages.llama-index-embeddings-huggingface.dist
  • python312Packages.llm-sentence-transformers
  • python312Packages.llm-sentence-transformers.dist
  • python312Packages.lm-eval
  • python312Packages.lm-eval.dist
  • python312Packages.manifest-ml
  • python312Packages.manifest-ml.dist
  • python312Packages.peacasso
  • python312Packages.peacasso.dist
  • python312Packages.peft
  • python312Packages.peft.dist
  • python312Packages.sentence-transformers
  • python312Packages.sentence-transformers.dist
  • python312Packages.smolagents
  • python312Packages.smolagents.dist
  • python312Packages.stanza
  • python312Packages.stanza.dist
  • python312Packages.translatehtml
  • python312Packages.translatehtml.dist
  • python312Packages.trl
  • python312Packages.trl.dist
  • python313Packages.accelerate
  • python313Packages.accelerate.dist
  • python313Packages.argos-translate-files
  • python313Packages.argos-translate-files.dist
  • python313Packages.argostranslate
  • python313Packages.argostranslate.dist
  • python313Packages.k-diffusion
  • python313Packages.k-diffusion.dist
  • python313Packages.langchain-huggingface
  • python313Packages.langchain-huggingface.dist
  • python313Packages.llama-index-embeddings-huggingface
  • python313Packages.llama-index-embeddings-huggingface.dist
  • python313Packages.llm-sentence-transformers
  • python313Packages.llm-sentence-transformers.dist
  • python313Packages.manifest-ml
  • python313Packages.manifest-ml.dist
  • python313Packages.peacasso
  • python313Packages.peacasso.dist
  • python313Packages.peft
  • python313Packages.peft.dist
  • python313Packages.sentence-transformers
  • python313Packages.sentence-transformers.dist
  • python313Packages.smolagents
  • python313Packages.smolagents.dist
  • python313Packages.stanza
  • python313Packages.stanza.dist
  • python313Packages.translatehtml
  • python313Packages.translatehtml.dist
  • python313Packages.trl
  • python313Packages.trl.dist
  • vectorcode
  • vectorcode.dist
  • vimPlugins.vectorcode-nvim

aarch64-darwin

✅ 81 packages built:
  • aider-chat-full
  • aider-chat-full.dist
  • aider-chat-with-help
  • aider-chat-with-help.dist
  • docling (python313Packages.docling)
  • docling-serve (python313Packages.docling-serve)
  • docling-serve.dist (python313Packages.docling-serve.dist)
  • docling.dist (python313Packages.docling.dist)
  • libretranslate (python313Packages.libretranslate)
  • libretranslate.dist (python313Packages.libretranslate.dist)
  • python312Packages.accelerate
  • python312Packages.accelerate.dist
  • python312Packages.argos-translate-files
  • python312Packages.argos-translate-files.dist
  • python312Packages.argostranslate
  • python312Packages.argostranslate.dist
  • python312Packages.docling
  • python312Packages.docling-serve
  • python312Packages.docling-serve.dist
  • python312Packages.docling.dist
  • python312Packages.k-diffusion
  • python312Packages.k-diffusion.dist
  • python312Packages.langchain-huggingface
  • python312Packages.langchain-huggingface.dist
  • python312Packages.libretranslate
  • python312Packages.libretranslate.dist
  • python312Packages.llama-index-embeddings-huggingface
  • python312Packages.llama-index-embeddings-huggingface.dist
  • python312Packages.llm-sentence-transformers
  • python312Packages.llm-sentence-transformers.dist
  • python312Packages.lm-eval
  • python312Packages.lm-eval.dist
  • python312Packages.manifest-ml
  • python312Packages.manifest-ml.dist
  • python312Packages.peacasso
  • python312Packages.peacasso.dist
  • python312Packages.peft
  • python312Packages.peft.dist
  • python312Packages.sentence-transformers
  • python312Packages.sentence-transformers.dist
  • python312Packages.smolagents
  • python312Packages.smolagents.dist
  • python312Packages.stanza
  • python312Packages.stanza.dist
  • python312Packages.translatehtml
  • python312Packages.translatehtml.dist
  • python312Packages.trl
  • python312Packages.trl.dist
  • python313Packages.accelerate
  • python313Packages.accelerate.dist
  • python313Packages.argos-translate-files
  • python313Packages.argos-translate-files.dist
  • python313Packages.argostranslate
  • python313Packages.argostranslate.dist
  • python313Packages.k-diffusion
  • python313Packages.k-diffusion.dist
  • python313Packages.langchain-huggingface
  • python313Packages.langchain-huggingface.dist
  • python313Packages.llama-index-embeddings-huggingface
  • python313Packages.llama-index-embeddings-huggingface.dist
  • python313Packages.llm-sentence-transformers
  • python313Packages.llm-sentence-transformers.dist
  • python313Packages.manifest-ml
  • python313Packages.manifest-ml.dist
  • python313Packages.peacasso
  • python313Packages.peacasso.dist
  • python313Packages.peft
  • python313Packages.peft.dist
  • python313Packages.sentence-transformers
  • python313Packages.sentence-transformers.dist
  • python313Packages.smolagents
  • python313Packages.smolagents.dist
  • python313Packages.stanza
  • python313Packages.stanza.dist
  • python313Packages.translatehtml
  • python313Packages.translatehtml.dist
  • python313Packages.trl
  • python313Packages.trl.dist
  • vectorcode
  • vectorcode.dist
  • vimPlugins.vectorcode-nvim

@GaetanLepage GaetanLepage merged commit 82adfab into NixOS:master Jul 6, 2025
27 of 29 checks passed
@sarahec sarahec deleted the accelerate-port-conflict-darwin branch July 6, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@bcdarwin bcdarwin Awaiting requested review from bcdarwin

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sarahec @GaetanLepage