Skip to content

python3Packages.{valkey,limits}: fix broken tests on Darwin#422850

Merged
mweinelt merged 5 commits intoNixOS:masterfrom
sarahec:py-valkey-darwin-tests
Jul 6, 2025
Merged

python3Packages.{valkey,limits}: fix broken tests on Darwin#422850
mweinelt merged 5 commits intoNixOS:masterfrom
sarahec:py-valkey-darwin-tests

Conversation

@sarahec
Copy link
Contributor

@sarahec sarahec commented Jul 6, 2025

python3Packages.valkey

  1. Cleanup
  2. Allow local networking (Darwin)
  3. Disable failing tests

python3Packages.limits (was broken in nixpkgs-review)

  1. Cleanup
  2. Add sarahec as maintainer
  3. Disable flaky tests
  4. Version bump

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jul 6, 2025
@sarahec sarahec requested a review from mweinelt July 6, 2025 04:10
@nixpkgs-ci nixpkgs-ci bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. labels Jul 6, 2025
@sarahec
Copy link
Contributor Author

sarahec commented Jul 6, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 422850
Commit: c44703367b447820e73c19b04e19e2e7f4c7dc81


aarch64-darwin

⏩ 8 packages marked as broken and skipped:
  • fittrackee
  • fittrackee.dist
  • irrd
  • irrd.dist
  • python312Packages.flask-appbuilder
  • python312Packages.flask-appbuilder.dist
  • python313Packages.flask-appbuilder
  • python313Packages.flask-appbuilder.dist
✅ 34 packages built:
  • calibre-web
  • calibre-web.dist
  • gitingest (python313Packages.gitingest)
  • gitingest.dist (python313Packages.gitingest.dist)
  • libretranslate (python313Packages.libretranslate)
  • libretranslate.dist (python313Packages.libretranslate.dist)
  • octoprint
  • octoprint.dist
  • python312Packages.flask-limiter
  • python312Packages.flask-limiter.dist
  • python312Packages.gitingest
  • python312Packages.gitingest.dist
  • python312Packages.libretranslate
  • python312Packages.libretranslate.dist
  • python312Packages.limits
  • python312Packages.limits.dist
  • python312Packages.logutils
  • python312Packages.logutils.dist
  • python312Packages.slowapi
  • python312Packages.slowapi.dist
  • python312Packages.valkey
  • python312Packages.valkey.dist
  • python313Packages.flask-limiter
  • python313Packages.flask-limiter.dist
  • python313Packages.limits
  • python313Packages.limits.dist
  • python313Packages.logutils
  • python313Packages.logutils.dist
  • python313Packages.slowapi
  • python313Packages.slowapi.dist
  • python313Packages.valkey
  • python313Packages.valkey.dist
  • theharvester
  • theharvester.dist

@sarahec sarahec requested a review from GaetanLepage July 6, 2025 04:42
@sarahec
Copy link
Contributor Author

sarahec commented Jul 6, 2025

@GaetanLepage the game of whack-a-mole continues... This is a prerequisite to multiple PRs.

@sarahec sarahec changed the title python3Packages.valkey: fix broken tests on Darwin python3Packages.{valkey,limits}: fix broken tests on Darwin Jul 6, 2025
@sarahec
Copy link
Contributor Author

sarahec commented Jul 6, 2025

Close before #422747

@mweinelt mweinelt merged commit 0cb87f1 into NixOS:master Jul 6, 2025
28 of 30 checks passed
@sarahec sarahec deleted the py-valkey-darwin-tests branch July 6, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants