Skip to content

treewide: add --extra-experimental-features nix-command to nix hash invocations#421823

Merged
philiptaron merged 1 commit intoNixOS:masterfrom
philiptaron:extra-experimental-commands-treewide
Jul 2, 2025
Merged

treewide: add --extra-experimental-features nix-command to nix hash invocations#421823
philiptaron merged 1 commit intoNixOS:masterfrom
philiptaron:extra-experimental-commands-treewide

Conversation

@philiptaron
Copy link
Contributor

Alyssa Ross prompted this with #418293 (comment)

I think this is ugly as sin and an indictment of the Nix feature process, but it's what we have today.

I did not run each of these scripts.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

@philiptaron philiptaron requested a review from alyssais July 2, 2025 15:36
@philiptaron philiptaron changed the title treewide: add --extra-experimental-features nix-command to nix hash invocations treewide: add --extra-experimental-features nix-command to nix hash invocations Jul 2, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: java Including JDK, tooling, other languages, other VMs 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 6.topic: dotnet Language: .NET labels Jul 2, 2025
Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eyeballed all changes, L(G)TM.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 2, 2025
@philiptaron philiptaron merged commit 0b9f5de into NixOS:master Jul 2, 2025
33 of 36 checks passed
@philiptaron philiptaron deleted the extra-experimental-commands-treewide branch July 2, 2025 19:06
@philiptaron philiptaron mentioned this pull request Aug 23, 2025
13 tasks
@mdaniels5757 mdaniels5757 added the 8.has: port to stable This PR already has a backport to the stable release. label Sep 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: dotnet Language: .NET 6.topic: java Including JDK, tooling, other languages, other VMs 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants