Conversation
Reduce script dependencies and improve compatibility
philiptaron
left a comment
There was a problem hiding this comment.
This PR doesn't actually do anything other than add you as a maintainer.
|
|
||
| # use friendlier hashes | ||
| darwin_hash=$(nix --extra-experimental-features nix-command hash convert --to sri --hash-algo sha256 "$darwin_hash") | ||
| darwin_hash="sha256-$(nix hash to-base64 "sha256:$darwin_hash")" |
There was a problem hiding this comment.
This reverts (kind of) #421823
This change looks wrong to me.
There was a problem hiding this comment.
Agreed. Also out of curiosity why aren't we using nix-hash --type sha256 --to-sri <hash> instead of the nix3 CLI? I know it's not really a big difference but tacking on the experimental features feels excessive when a simpler command will do.
I got the error: 'convert' is not a recognized command when running the script |
The |
It might be that I used lix which caused the error, but I think the script should minimize dependencies as much as possible, since both methods achieve the same result |
Honestly I agree with you. I think these scripts should be using |
Reduce script dependencies and improve compatibility
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.