dingtalk: init linux at 8.1.0.6021101 and darwin at 8.2.10#431371
dingtalk: init linux at 8.1.0.6021101 and darwin at 8.2.10#431371Nyxvectar wants to merge 1 commit intoNixOS:masterfrom
Conversation
acid-bong
left a comment
There was a problem hiding this comment.
Evening and welcome to Nixpkgs. Here's a couple notes.
And a general one: in this PR only two commits should remain, new maintainer and, after it, new package.
4cb7b5f to
6450d7f
Compare
Thank you for your welcome. I have kept the necessary two commits, though I forced pushed so many times (laugh |
|
The first commit's title should be "maintainers: add nyxvectar", no |
256707c to
8f1ee59
Compare
Nyxvectar
left a comment
There was a problem hiding this comment.
The first commit's title should be "maintainers: add nyxvectar", no
@
Done.
|
@Nyxvectar Thanks for your PR at first. I hope to know if the package is already working and ready to merge? From my side, I'm not with the unstable branch but nixos-24.04 (https://github.com/dvorak0/nixpkgs/tree/nixos-24.05-dingtalk), I cherry-pick the commit and found it's failed to build it. Any advance on this issue would be super helpful to me. Thanks. |
|
@dvorak0 Thank you so much for reviewing the PR and highlighting the build issues. I'll try to make time to investigate and address these problems, though due to current academic commitments, it might take a while to deliver a fix. I appreciate your patience! If you’re interested in helping move this pull request forward, I’d be very happy to support however possible. |
|
Due to no Darwin devices, temporarily postpone the darwin dingtalk pkg. |
Prince213
left a comment
There was a problem hiding this comment.
Tested on aarch64-darwin that the app can launch.
Feel free to add me to Co-authored-by if you wish to incorporate these changes.
12b1c2a to
f3599db
Compare
Prince213
left a comment
There was a problem hiding this comment.
Tested that the app can launch on aarch64-darwin.
|
Hi, just checked: I cherry-picked the commit to my branch (https://github.com/dvorak0/nixpkgs/tree/nixos-24.05-dingtalk) it's still not working. It's probably because I'm still on NixOS 24.04. The following log is for your reference: |
Around 4 days ago we have replaced |
|
#367674 Replaced all existing configurations or dependencies that originally relied on or referenced the |
|
24.05 is long unsupported so I'll consider it as a wont-fix. You should upgrade to a supported release like 25.05. Keep stateVersion fixed at 24.05 and no breakage should happen. |
|
Hi @Nyxvectar, I'm curious, if the desktop notification working well in your side? The version I'm using right now (https://github.com/nix-community/nur-combined/blob/main/repos/xddxdd/pkgs/uncategorized/dingtalk/default.nix#L239) fails to send notification. |
Correct, it has sounds and flickering, but no notification with Desktop Notification Enabled. |
|
Feedback. The current packaging crash whenever I download something others send to me. I have to switch to flathub version: https://flathub.org/en/apps/com.dingtalk.DingTalk/install . I still hope we could solve the download issue. |
|
Upgrading the pull request from |
|
dingtalk on Linux has been updated to version 8.1.0.6021101 |
|
Copied. Check later. |
惊为天人。

Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.