linux_latest-libre: 19812 -> 19835#418293
Merged
philiptaron merged 3 commits intoNixOS:masterfrom Jul 2, 2025
Merged
Conversation
nix-owners
bot
requested review from
Ma27,
NeQuissimus,
TredwellGit,
alyssais and
thoughtpolice
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
added
10.rebuild-darwin: 0
Member
You should be able to test this via the kernel-generic test at least fwiw. But then... how long is this broken now? |
Contributor
Author
|
I'd prefer to just merge a fix considering the update script was sufficient. I just upgraded it since I took a look at the contents. |
alyssais
requested changes
Jun 21, 2025
Member
alyssais
left a comment
alyssais
left a comment
There was a problem hiding this comment.
We might as well get this merged in the meantime even if the outcome of the discussion is to drop it. FWIW: I added linux-libre to Nixpkgs many years ago, and I have no objections to dropping it.
Member
|
fwiw for me, the blocking part was that noone else was interested enough to verify that it boots (which is what I did yesterday, but got distracted by something else for GPN-reasons, so I didn't give feedback). |
Contributor
Author
|
Alyssa: the ❌ is for splitting the commit and nothing else, correct? |
philiptaron
force-pushed
the
linux-libre-fix-build
branch
from
f4a9a3d to
b0ec9fb
Compare
philiptaron
changed the title
Contributor
Author
|
I've addressed the commit-splitting feedback, ran the update script which yielded a new revision, and ran the |
This comment was marked as outdated.
This comment was marked as outdated.
alyssais
requested changes
Jul 2, 2025
philiptaron
force-pushed
the
linux-libre-fix-build
branch
from
b0ec9fb to
4cb34ef
Compare
13 tasks
alyssais
approved these changes
Jul 2, 2025
Contributor
Author
|
Contributor
Author
|
Contributor
|
Successfully created backport PR for |
1 task
github-actions
bot
added
the
8.has: port to stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, update the phases to run their hooks, and the hash to be SRI, and the update script to support that.
This fixes the build. I don't have great passion for Linux Libre; I just wanted to see fewer of these build failures being "expected". Though I did not attempt to boot the kernel on a real machine, I did run the
nixosTests.kernel-generic.linux_libretest and the machine does in fact boot and do the needful.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)