microsoft-edge: refresh package by Soveu · Pull Request #421185 · NixOS/nixpkgs

Soveu · 2025-06-30T08:33:47Z

As this package from 25.05 is unmaintained, I can step up to be responsible for it.
Basically, I started from scratch, it turned out to be relatively easy.

Edge also required the libxml2 workaround, see those:

Testing locally, I was able to successfully sync Edge with my company account and also I don't see any major errors in logs.

Things done

Updated version to 138.0.3351.55-1, use autoPatchelfHook and qt6.wrapQtAppsHook, remove the packaged QT5 shim.

Add a 👍 reaction to pull requests you find important.

Daholli · 2025-06-30T08:46:33Z

I'm a bit confused with this change, I'll have a look when I'm at my PC.

Soveu · 2025-06-30T08:49:57Z

I'm a bit confused with this change, I'll have a look when I'm at my PC.

What confuses you?

isabelroses · 2025-06-30T08:45:45Z

pkgs/by-name/mi/microsoft-edge/package.nix

I'd rather not move back to the rec could you keep the finalAttrs

isabelroses · 2025-06-30T08:47:56Z

pkgs/by-name/mi/microsoft-edge/package.nix

I'm not sure you should just remove all these people. They all clearly have interest in the package and are active.

See:

microsoft-edge: 137.0.3296.83 -> 137.0.3296.93 #419268

microsoft-edge: 137.0.3296.68 -> 137.0.3296.83 #417925

microsoft-edge: remove dependency to stdenv #415521

Hmm, then it is interesting why after update to 25.05 I got message that the package is unmaintained 🤔

The package was briefly removed due to there only being one maintainer. Then all these lovely people stepped up :D

Thank you from not removing us from the maintainers list 🙂

isabelroses · 2025-06-30T08:48:29Z

pkgs/by-name/mi/microsoft-edge/package.nix

could we at least replace the update script :p

maeve-oake · 2025-06-30T08:51:48Z

The package is not unmaintained. The current maintainers were added after the package was removed for lack of maintenance recently in the commits that Isabel linked above

Please feel free to add yourself as a new maintainer though!

isabelroses · 2025-06-30T08:53:06Z

maintainers/maintainer-list.nix

+  Soveu = {
+    name = "Soveu";
+    github = "Soveu";
+    githubId = 34382234;
+  };


This should be in its own commit before the commit altering microsoft-edge. The commit should be called maintainers: add Soveu see https://github.com/NixOS/nixpkgs/blob/master/maintainers/README.md#how-to-become-a-maintainer for more detail.

Soveu · 2025-06-30T08:53:17Z

The package is not unmaintained. The current maintainers were added after the package was removed for lack of maintenance recently in the commits that Isabel linked above

Please feel free to add yourself as a new maintainer though!

oh, then I'm late to the party 😅 Sorry for the confusion

Daholli · 2025-06-30T08:54:47Z

you can just change the PR to instead update to 138.0.3351.55 I was out for the weekend and didn't have time to update the version yet

isabelroses · 2025-06-30T08:55:31Z

pkgs/by-name/mi/microsoft-edge/package.nix

 in
-
-stdenvNoCC.mkDerivation (finalAttrs: {
+stdenv.mkDerivation rec {


Also should note that this was specifically moved to stdenvNoCC (see #415521) is there a reason for moving it back?

I think he started more or less from a blank file and was not aware we already took over maintaining the package

dependency is needed for stdenv.cc.cc in buildDependencies

Daholli · 2025-06-30T08:55:53Z

And since we aren't the original code owners, maybe it does make sense to use autopatchelf instead, but for that I want to first understand why it was done this way deliberately

Soveu · 2025-06-30T08:56:34Z

you can just change the PR to instead update to 138.0.3351.55 I was out for the weekend and didn't have time to update the version yet

There is a lot more going on for this package - basically I assumed it was still unmaintained and started from scratch, because the original derivation was... very convoluted to say the least

Daholli · 2025-06-30T08:58:29Z

you can just change the PR to instead update to 138.0.3351.55 I was out for the weekend and didn't have time to update the version yet

There is a lot more going on for this package - basically I assumed it was still unmaintained and started from scratch, because the original derivation was... very convoluted to say the least

Yeah there is a lot going on, but since presumably most of it was done deliberately I would be careful before just changing it

alyssais · 2025-06-30T09:02:19Z

pkgs/by-name/mi/microsoft-edge/package.nix

+      url = "mirror://gnome/sources/libxml2/${lib.versions.majorMinor version}/libxml2-${version}.tar.xz";
+      hash = "sha256-J3KUyzMRmrcbK8gfL0Rem8lDW4k60VuyzSsOhZoO6Eo=";
+    };
+  };


Going out of our way to use a known vulnerable libxml2 version in a web browser does not seem like a good idea to me.

Agreeing on behalf of @NixOS/security.

@ulrikstrid Please review and respond to this PR.

Bricklou · 2025-06-30T09:02:23Z

you can just change the PR to instead update to 138.0.3351.55 I was out for the weekend and didn't have time to update the version yet

Hey, where did you see that 138.0.3351.55 was available? I don't see it in this list.

Daholli · 2025-06-30T09:02:35Z

pkgs/by-name/mi/microsoft-edge/package.nix

-      mv "$icon_file" "$logo_output_path/microsoft-edge.png"
-    done
-
-    # "--simulate-outdated-no-au" disables auto updates and browser outdated popup


We should not leave this out, since otherwise you keep get annoying popups

Daholli · 2025-06-30T09:07:18Z

could we just reject this PR and then just open a PR to refactor potentially convoluted parts without using the libxml workaround?

Soveu · 2025-06-30T09:07:53Z

you can just change the PR to instead update to 138.0.3351.55 I was out for the weekend and didn't have time to update the version yet

Hey, where did you see that 138.0.3351.55 was available? I don't see it in this list.

Hmm, while looking for newest version I just look directly inside https://packages.microsoft.com/repos/edge/pool/main/m/microsoft-edge-stable/

Soveu · 2025-06-30T09:08:17Z

could we just reject this PR and then just open a PR to refactor potentially convoluted parts without using the libxml workaround?

Yeah

Bricklou · 2025-06-30T09:09:49Z

On my side, I'm not sure about this refactor. A lot of dependencies seems to be removed (like all the qt plugins or all the wayland/ozone packages) without really knowing the consequences afterward. (Please explain me if I missed something)

Daholli · 2025-06-30T09:11:22Z

I will go back to work... my phone started blowing up, @Soveu if you want to, you could open an Issue, then we can discuss potential refactor steps there

Bricklou · 2025-06-30T09:13:24Z

i suggest we do open 2 PRs :

one for the 138.0.3351.55 update
another one dedicated on the package refactor (after being discussed in an issue)

Soveu · 2025-06-30T09:14:19Z

I will go back to work... my phone started blowing up, @Soveu if you want to, you could open an Issue, then we can discuss potential refactor steps there

Sure, no pressure 😉

On my side, I'm not sure about this refactor. A lot of dependencies seems to be removed (like all the qt plugins or all the wayland/ozone packages) without really knowing the consequences afterward. (Please explain me if I missed something)

It was not needed to make it work and as far as I know, wayland/ozone is only necessary for nvidia users? And even then I'm not sure if they really need it on newer GPU drivers.

Bricklou · 2025-06-30T09:23:16Z

It was not needed to make it work and as far as I know, wayland/ozone is only necessary for nvidia users? And even then I'm not sure if they really need it on newer GPU drivers.

Hum, no ? Wayland/Ozone isn't tied to nvidia, it is there to actually run the browser in DE using wayland (like gnome or KDE).
Though, i don't know the details about the package requirements by itself.

nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 30, 2025

nix-owners bot requested review from Bricklou, Daholli, maeve-oake and ulrikstrid June 30, 2025 08:40

Soveu force-pushed the msedge branch from 92fdd7a to 3dc52a3 Compare June 30, 2025 08:45

microsoft-edge: refresh package

aadf162

Soveu force-pushed the msedge branch from 3dc52a3 to aadf162 Compare June 30, 2025 08:48

isabelroses reviewed Jun 30, 2025

View reviewed changes

nixpkgs-ci bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jun 30, 2025

isabelroses reviewed Jun 30, 2025

View reviewed changes

alyssais requested a review from a team June 30, 2025 09:01

alyssais reviewed Jun 30, 2025

View reviewed changes

Daholli suggested changes Jun 30, 2025

View reviewed changes

Soveu mentioned this pull request Jun 30, 2025

maintainers: add Soveu #421190

Closed

13 tasks

Daholli closed this Jun 30, 2025

Soveu mentioned this pull request Jun 30, 2025

microsoft-edge: Potential refactor of the package #421194

Closed

Uh oh!

Conversation

Soveu commented Jun 30, 2025

Things done

Uh oh!

Daholli commented Jun 30, 2025

Uh oh!

Soveu commented Jun 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maeve-oake commented Jun 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Soveu commented Jun 30, 2025

Uh oh!

Daholli commented Jun 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Daholli commented Jun 30, 2025

Uh oh!

Soveu commented Jun 30, 2025

Uh oh!

Daholli commented Jun 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Bricklou commented Jun 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Daholli commented Jun 30, 2025

Uh oh!

Soveu commented Jun 30, 2025

Uh oh!

Soveu commented Jun 30, 2025

Uh oh!

Bricklou commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Daholli commented Jun 30, 2025

Uh oh!

Bricklou commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Soveu commented Jun 30, 2025

Uh oh!

Bricklou commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Bricklou commented Jun 30, 2025 •

edited

Loading

Bricklou commented Jun 30, 2025 •

edited

Loading

Bricklou commented Jun 30, 2025 •

edited

Loading