Skip to content

microsoft-edge: 137.0.3296.68 -> 137.0.3296.83#417925

Merged
Aleksanaa merged 2 commits intomasterfrom
unknown repository
Jun 19, 2025
Merged

microsoft-edge: 137.0.3296.68 -> 137.0.3296.83#417925
Aleksanaa merged 2 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Jun 18, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 18, 2025
Bricklou
Bricklou approved these changes Jun 18, 2025
View reviewed changes
Copy link
Contributor

@Bricklou Bricklou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Run without issue locally.

@github-actions github-actions bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jun 18, 2025
@maeve-oake
Copy link
Contributor

maeve-oake commented Jun 19, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 417925
Commit: d20e9d5bcb628c2cfe3b862045210255e0040262

x86_64-linux

✅ 1 package built:
  • microsoft-edge

@Aleksanaa Aleksanaa merged commit 52e1823 into NixOS:master Jun 19, 2025
24 of 26 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jun 19, 2025

Successfully created backport PR for release-25.05:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Jun 19, 2025
Merged
1 task
@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jun 19, 2025
@ghost ghost deleted the microsoft-edge branch June 19, 2025 17:08
@ghost ghost removed request for Daholli and ulrikstrid June 19, 2025 17:08
@mweinelt
Copy link
Member

mweinelt commented Jun 23, 2025 •
edited
Loading

Not backported to 24.11, which still has support until the end of the month.

@emilylange emilylange mentioned this pull request Jun 23, 2025
Merged
13 tasks
@isabelroses isabelroses mentioned this pull request Jun 30, 2025
Closed
13 tasks
@ghost ghost removed 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. labels Jul 11, 2025
@ghost ghost removed 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. backport release-25.05 labels Jul 11, 2025
@goyalyashpal
Copy link

goyalyashpal commented Jul 18, 2025

@ emaryn removed all labels
- #417925 (comment)

@ emaryn removed all labels
- #415521 (comment)

i have not seen this in any other project before.
so curious to know the reason 😃

@Daholli
Copy link
Member

Daholli commented Jul 21, 2025 •
edited
Loading

It looks like that was a script, judging by her now private github.
#425953

very sad to see this as she was doing so much good

@drupol
Copy link
Contributor

drupol commented Jul 21, 2025

It looks like that was a script, judging by her now private github. #425953

Their github has always been private and I don't consider this as an issue. I don't think there's a requirement in this community to have a public and accessible profile.

very sad to see this as she was doing so much good

True, I am very sad of this.

@drupol
Copy link
Contributor

drupol commented Jul 21, 2025

i have not seen this in any other project before. so curious to know the reason 😃

Perhaps you could simply ask directly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@maeve-oake @mweinelt @goyalyashpal @Daholli @drupol @Bricklou @Aleksanaa