Skip to content

microsoft-edge: remove dependency to stdenv#415521

Merged
ulrikstrid merged 2 commits intomasterfrom
unknown repository
Jun 10, 2025
Merged

microsoft-edge: remove dependency to stdenv#415521
ulrikstrid merged 2 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Jun 10, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels Jun 10, 2025
@Daholli
Copy link
Member

Daholli commented Jun 10, 2025

should I remove your name from the backports then?

@Daholli
Copy link
Member

Daholli commented Jun 10, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 415521
Commit: e85e8cc51cf77013aed2924ccc78823e37b83f5d


x86_64-linux

✅ 1 package built:
  • microsoft-edge

@ulrikstrid ulrikstrid merged commit f948e44 into NixOS:master Jun 10, 2025
16 of 18 checks passed
@ghost ghost deleted the edge branch June 10, 2025 15:51
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jun 11, 2025

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-415521-to-release-24.11 origin/release-24.11
cd .worktree/backport-415521-to-release-24.11
git switch --create backport-415521-to-release-24.11
git cherry-pick -x f9bf016cc83c960e616b674bcb85c0e945a2fbd7 e85e8cc51cf77013aed2924ccc78823e37b83f5d

@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jun 11, 2025

Successfully created backport PR for release-25.05:

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jun 11, 2025
@isabelroses isabelroses mentioned this pull request Jun 30, 2025
13 tasks
@ghost ghost removed 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. backport release-25.05 labels Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants