Skip to content

citrix-workspace: fix libxml2 build incompatibility#418543

Merged
khaneliman merged 1 commit intoNixOS:masterfrom
khaneliman:citrix-workspace
Jun 24, 2025
Merged

citrix-workspace: fix libxml2 build incompatibility#418543
khaneliman merged 1 commit intoNixOS:masterfrom
khaneliman:citrix-workspace

Conversation

@khaneliman
Copy link
Contributor

@khaneliman khaneliman commented Jun 20, 2025 •
edited
Loading

Breaking ABI change for libxml2 recently, need to override to use supported libxml version. #396195 (comment)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 20, 2025
@nix-owners nix-owners bot requested a review from flacks June 20, 2025 21:20
@khaneliman khaneliman marked this pull request as draft June 21, 2025 19:26
@khaneliman khaneliman marked this pull request as ready for review June 21, 2025 21:03
@khaneliman khaneliman changed the title citrix-workspace: fix build citrix-workspace: fix libxml2 build incompatibility Jun 21, 2025
@khaneliman
citrix-workspace: fix libxml2 build incompatibility
27d6186 
Breaking ABI change for libxml2 recently, need to override to use
supported libxml version.

Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
@mhutter
Copy link
Contributor

mhutter commented Jun 23, 2025

This changes fixes the build for citrix_workspace_24_08_0

mhutter added a commit to mhutter/nix that referenced this pull request Jun 23, 2025
@mhutter
Update systems; work around NixOS/nixpkgs#418543
dbc82d7 
Signed-off-by: Manuel Hutter <manuel@hutter.io>
@ryand56 ryand56 mentioned this pull request Jun 24, 2025
Closed
3 tasks
@eclairevoyant eclairevoyant mentioned this pull request Jun 24, 2025
Merged
13 tasks
flacks
flacks approved these changes Jun 24, 2025
View reviewed changes
Copy link
Contributor

@flacks flacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@khaneliman khaneliman merged commit c4d68f0 into NixOS:master Jun 24, 2025
26 of 27 checks passed
@khaneliman khaneliman deleted the citrix-workspace branch June 24, 2025 20:48
mhutter added a commit to mhutter/nix that referenced this pull request Jun 25, 2025
@mhutter
fix(omnissa-horizon-client): Use pinned libxml2 version
4a9e4ec 
There were breaking ABI changes in libxml2 v2.14; this commit uses a
pinned version thereof instead.

See: NixOS/nixpkgs#418543
Signed-off-by: Manuel Hutter <manuel@hutter.io>
mhutter added a commit to mhutter/nix that referenced this pull request Jun 25, 2025
@mhutter
Revert "Update systems; work around NixOS/nixpkgs#418543"
3f58751 
This reverts commit dbc82d7.
@Soveu Soveu mentioned this pull request Jun 30, 2025
Closed
13 tasks
@emilazy
Copy link
Member

emilazy commented Jun 30, 2025

This version has an unfixed CVE, it may need at least knownVulnerabiliies.

@alyssais
Copy link
Member

alyssais commented Jun 30, 2025

#421204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@flacks flacks flacks approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@khaneliman @mhutter @emilazy @alyssais @flacks