Conversation
github-actions
bot
added
10.rebuild-darwin: 11-100
pbsds
force-pushed
the
migrate-py311-to-py312-1748437820
branch
from
62feac2 to
2a2b9ed
Compare
|
|
i dug through the git history to see why they were pinned to begin with, i ended up reverting two of my original commits |
|
|
Hey! I maintain freecad. I noticed you unpinned python on it, and i wasn't pinged (likely because too many packages). Following problem: nixpkgs/pkgs/by-name/fr/freecad/package.nix Line 128 in ee930f9 This was broken for python 3.12 and was kept alive with extensive patching, making 3.12 work now. However, since #407932, it is marked broken for 3.13. The current I also suspect freecad is not the only package of this lot depending on |
| }: | ||
| let | ||
| inherit (python311Packages) | ||
| inherit (python3Packages) |
There was a problem hiding this comment.
For freecad, the correct change would have been 2485c74, also described in #408577 (review)
| python311Packages.shiboken2 | ||
| python3Packages.pyside2 | ||
| python3Packages.pyside2-tools | ||
| python3Packages.shiboken2 |
|
A comment in the code would've helped me 😅 Thanks for staying on top of this, should i/you open a fix PR or should we do so in the PR you linked? I'll subscribe to it nonetheless |
|
The PR i linked has other issues, notably the freecad plugin it attempts to introduce just segfaults. So this should be a separate PR. I'd appreciate if you do renderdoc. As for freecad, i already considered straight dropping the qt5 version (which would actually allow unpinning python) |
|
And yes, a comment would have helped, but i wasn't the one pinning the python... These things really are not super discoverable, and i just found your PR by chance when i went poking at freecad for dropping qt5. |
|
Qt5 support is was officially reduced by qt [1]. FreeCAD supports both Qt5 and Qt6. While their github build still uses Qt5, the official flatpak uses Qt6 [2]. Additionally, keeping Qt5 support requires pinning python to 3.12 or older, as shiboken2 would break. Currently, this breakage is imminent: NixOS#412204 unpinned python, with the next staging-next merge updating py to 3.13. [1] https://www.qt.io/blog/extended-security-maintenance-for-qt-5.15-begins-may-2025 [2] https://github.com/flathub/org.freecad.FreeCAD/blob/ad843adc0a29a2c78bdd60624376aab61445ed63/org.freecad.FreeCAD.yaml#L62
3 participants
Approach was simple: unpin python311 and see if it builds, if it didn't it try and fix it
guake: unpin python311sapling: unpin python311Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.