freecad: remove qt5 and explicit wayland builds#416741
Conversation
Qt5 support is was officially reduced by qt [1]. FreeCAD supports both Qt5 and Qt6. While their github build still uses Qt5, the official flatpak uses Qt6 [2]. Additionally, keeping Qt5 support requires pinning python to 3.12 or older, as shiboken2 would break. Currently, this breakage is imminent: NixOS#412204 unpinned python, with the next staging-next merge updating py to 3.13. [1] https://www.qt.io/blog/extended-security-maintenance-for-qt-5.15-begins-may-2025 [2] https://github.com/flathub/org.freecad.FreeCAD/blob/ad843adc0a29a2c78bdd60624376aab61445ed63/org.freecad.FreeCAD.yaml#L62
Qt will figure out which platform plugin to use. Many of our packages already explicitly unset `QT_QPA_PLATFORM`, it makes little sense to force it here.
|
|
Hmm i might also be able to clean up the wrapping, this currently triple-wraps... |
8747dcf to
d72cbf5
Compare
|
Indeed passthru tests still work (which do check the python path) |
|
(oops, misclick with the close...) |
| "-DSHIBOKEN_INCLUDE_DIR=${python3Packages.shiboken6}/include" | ||
| "-DSHIBOKEN_LIBRARY=Shiboken6::libshiboken" | ||
| ( | ||
| "-DPYSIDE_INCLUDE_DIR=${python3Packages.pyside6}/include" | ||
| + ";${python3Packages.pyside6}/include/PySide6/QtCore" | ||
| + ";${python3Packages.pyside6}/include/PySide6/QtWidgets" | ||
| + ";${python3Packages.pyside6}/include/PySide6/QtGui" |
There was a problem hiding this comment.
Doesn't actually append /include, it only would get the $include output. And pyside6 only has the one default output. So would not do anything.
|
|
The python wrapper usually also adds the |
The python wrapper wasn't even used before i think - even before it was just |
|
Ah, my eyes skipped past the old |

Qt5 support is was officially reduced by qt [1].
FreeCAD supports both Qt5 and Qt6. While their github
build still uses Qt5, the official flatpak uses Qt6 [2].
Additionally, keeping Qt5 support requires pinning
python to 3.12 or older, as shiboken2 would break.
Currently, this breakage is imminent: #412204 unpinned
python, with the next staging-next merge updating py to 3.13.
Qt will figure out which platform plugin to use. Many of our packages already explicitly unset
QT_QPA_PLATFORM, it makes little sense to force it here.[1] https://www.qt.io/blog/extended-security-maintenance-for-qt-5.15-begins-may-2025
[2] https://github.com/flathub/org.freecad.FreeCAD/blob/ad843adc0a29a2c78bdd60624376aab61445ed63/org.freecad.FreeCAD.yaml#L62
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.