CONTRIBUTING: Add guideline to document motivation for special packaging choices#416728
Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom Jun 27, 2025
Merged
Conversation
Member
|
I made this days ago: #416157 |
Member
Author
|
Hey neat! These are not mutually exclusive however, and repetition legitimizes 👍 |
13 tasks
Aleksanaa
reviewed
Jun 14, 2025
810560e to
612a69d
Compare
612a69d to
e393725
Compare
e393725 to
00caa90
Compare
13 tasks
…ing choices This helps with retaining domain knowledge, sorely needed during treewide fixups and bumps.
00caa90 to
0930b56
Compare
wolfgangwalther
approved these changes
Jun 19, 2025
13 tasks
Contributor
|
I'd say let's do this, because nobody objected to it (and I don't see a reason to do so, really). |
3 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps with retaining domain knowledge, sorely needed during treewide fixups and bumps.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.