renderdoc: fallback to python312 if shiboken2 is not available, adopt#416726
Merged
pbsds merged 2 commits intoNixOS:masterfrom Jun 15, 2025
Merged
renderdoc: fallback to python312 if shiboken2 is not available, adopt#416726pbsds merged 2 commits intoNixOS:masterfrom
pbsds merged 2 commits intoNixOS:masterfrom
Conversation
shiboken2 is marked broken on python313, and python3 will default to python313 in the next staging-next merge
Upstream is a bit unresponsive to certain issues, but this package deserves some love. I'll modernize it later.
4e52074 to
b39cad0
Compare
LordGrimmauld
approved these changes
Jun 14, 2025
Contributor
LordGrimmauld
left a comment
There was a problem hiding this comment.
thanks for taking care of this one :)
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shiboken2 is marked broken on python313, and python3 will default to python313 in the next staging-next merge
Upstream is a bit unresponsive to certain issues, but I still frequently use this and this package deserves some love. I'll modernize it later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.