Skip to content

renderdoc: fallback to python312 if shiboken2 is not available, adopt#416726

Merged
pbsds merged 2 commits intoNixOS:masterfrom
pbsds:feat-renderdoc-pin-py312-1749915397
Jun 15, 2025
Merged

renderdoc: fallback to python312 if shiboken2 is not available, adopt#416726
pbsds merged 2 commits intoNixOS:masterfrom
pbsds:feat-renderdoc-pin-py312-1749915397

Conversation

@pbsds
Copy link
Member

@pbsds pbsds commented Jun 14, 2025

  • renderdoc: fallback to python312 if shiboken2 is not available
  • renderdoc: add pbsds to maintainers

shiboken2 is marked broken on python313, and python3 will default to python313 in the next staging-next merge

Upstream is a bit unresponsive to certain issues, but I still frequently use this and this package deserves some love. I'll modernize it later.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@pbsds pbsds mentioned this pull request Jun 14, 2025
13 tasks
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 14, 2025
pbsds added 2 commits June 14, 2025 18:02
shiboken2 is marked  broken on python313, and python3 will default to python313 in the next staging-next merge
Upstream is a bit unresponsive to certain issues, but this package deserves some love.
I'll modernize it later.
@pbsds pbsds force-pushed the feat-renderdoc-pin-py312-1749915397 branch from 4e52074 to b39cad0 Compare June 14, 2025 16:03
Copy link
Contributor

@LordGrimmauld LordGrimmauld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking care of this one :)

@pbsds pbsds merged commit 82022ab into NixOS:master Jun 15, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants