vscode-utils.buildVscodeExtension: set passthru.updateScript default to vscode-extension-update-script#404503
Conversation
…to vscode-extension-update-script
github-actions
bot
added
6.topic: vscode
ghost
marked this pull request as ready for review
drupol
reviewed
May 6, 2025
| { | ||
| updateScript = vscode-extension-update-script { }; | ||
| } | ||
| // passthru |
Contributor
There was a problem hiding this comment.
@ShamrockLee Can you have a look at this and let me know if this is the proper way to do this?
Contributor
There was a problem hiding this comment.
I'll take a look this wekend.
Contributor
There was a problem hiding this comment.
I haven't read through the complete update script. Here are some comments:
- Update scripts based on
vsceis certainly a good idea. - Current
vscode-utils.fetchVsixFromVscodeMarketplaceuses the "legacy" URL pattern instead of the one currently used by VSCode to download the extensions. I had a concern that it didn't supporttargetPlatformaside from `universal (nix-prefetch-vscode-marketplace, nix-prefetch-openvsx: init at 0.1.0 #161369 (comment)), but such concern is now addressed by PR vscode-extensions.ms-vscode.cpptools: 1.9.1 -> 1.11.0 #178513.
ghost
mentioned this pull request
13 tasks
ghost
removed
10.rebuild-darwin: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This script has been in use for some time, and I think it can now be set as the default to reduce the maintenance burden on maintainers. It is used in #396204 #395472. It was used in the following bulk updates #399772 #396986
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.