vscode-extensions.ms-vscode.cpptools: 1.9.1 -> 1.11.0#178513
Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom Jul 7, 2022
Merged
vscode-extensions.ms-vscode.cpptools: 1.9.1 -> 1.11.0#178513SuperSandro2000 merged 1 commit intoNixOS:masterfrom
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
Conversation
13 tasks
Member
Author
|
@eadwu @jraygauthier @firmero do you have any tips or comments for this PR? |
vlaci
approved these changes
Jun 30, 2022
pkgs/applications/editors/vscode/extensions/cpptools/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/editors/vscode/extensions/cpptools/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/editors/vscode/extensions/cpptools/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/editors/vscode/extensions/cpptools/default.nix
Outdated
Show resolved
Hide resolved
Member
There was a problem hiding this comment.
Suggested change
| archurl = (if arch == "" then "" else "?targetPlatform=${arch}"); | |
| archurl = lib.optionalString (arch != "") "?targetPlatform=${arch}"; |
Member
Author
There was a problem hiding this comment.
This would require a dependency on lib, which in turn would require changes to the rest of the vscode extension build system. Is that worth it?
pkgs/applications/editors/vscode/extensions/mktplcExtRefToFetchArgs.nix
Outdated
Show resolved
Hide resolved
jraygauthier
approved these changes
Jul 5, 2022
vlaci
approved these changes
Jul 6, 2022
| @@ -1,6 +1,9 @@ | |||
| { publisher, name, version, sha256 ? "" }: | |||
| { publisher, name, version, arch ? "", sha256 ? "" }: | |||
Member
There was a problem hiding this comment.
Suggested change
| { publisher, name, version, arch ? "", sha256 ? "" }: | |
| { lib } | |
| { publisher, name, version, arch ? "", sha256 ? "" }: |
We can't do this, right? If not then we can use if else to save us all the changes.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/vscode-cpptools-opendebugad7-is-broken-in-nixpkgs/17581/3 |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR was forked from #151228, it inherits some changes such as the removal of
mono, and the automatic wrapping of the debugger. Based on the work by @vlaci .ms-vscode.cpptoolsVisual Studio Code extension to version1.11.0buildVscodeMarketplaceExtensiondownload and unpacking functionalityOpenDebugAD7Related issues:
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes