Skip to content

vscode-extensions.ms-dotnettools.csdevkit: remove update script#407178

Merged
drupol merged 1 commit intomasterfrom
unknown repository
May 15, 2025
Merged

vscode-extensions.ms-dotnettools.csdevkit: remove update script#407178
drupol merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented May 14, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 14, 2025
@ghost ghost requested a review from GGG-KILLER May 15, 2025 02:27
@GGG-KILLER
Copy link
Contributor

Why is the update script being removed if it is still being used?

The last r-ryantm update even mentions it used it to update it:

This update was made based on information from passthru.updateScript.

@GGG-KILLER
Copy link
Contributor

Since #404503 has already provided a default update script for vscode-utils.buildVscodeExtension, it should be sufficient to replace the update script functionality of this package.

Oh I hadn't seen that PR, thanks for your work!

The same is being done in ms-dotnettools.csharp so I assume we can get rid of that update script as well?

@GGG-KILLER GGG-KILLER added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels May 15, 2025
@drupol drupol merged commit 6708880 into NixOS:master May 15, 2025
21 of 23 checks passed
@ghost ghost deleted the csdevkit branch May 15, 2025 04:59
@ghost ghost removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 6.topic: vscode A free and versatile code editor that supports almost every major programming language. labels Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants