Skip to content

vscode-utils.buildVscodeExtension: set passthru.updateScript default to vscode-extension-update-script #404503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drupol merged 1 commit into from May 12, 2025
Merged

vscode-utils.buildVscodeExtension: set passthru.updateScript default to vscode-extension-update-script #404503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions pkgs/applications/editors/vscode/extensions/vscode-utils.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
vscode,
unzip,
jq,
vscode-extension-update-script,
}:
let
buildVscodeExtension = lib.extendMkDerivation {
Expand Down Expand Up @@ -40,9 +41,14 @@ let
{
pname = "vscode-extension-${pname}";

passthru = passthru // {
inherit vscodeExtPublisher vscodeExtName vscodeExtUniqueId;
};
passthru =
{
updateScript = vscode-extension-update-script { };
}
// passthru
Copy link
Copy Markdown
Contributor

@drupol drupol May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShamrockLee Can you have a look at this and let me know if this is the proper way to do this?

Copy link
Copy Markdown
Contributor

@ShamrockLee ShamrockLee May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take a look this wekend.

Copy link
Copy Markdown
Contributor

@ShamrockLee ShamrockLee May 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't read through the complete update script. Here are some comments:

  1. Update scripts based on vsce is certainly a good idea.
  2. Current vscode-utils.fetchVsixFromVscodeMarketplace uses the "legacy" URL pattern instead of the one currently used by VSCode to download the extensions. I had a concern that it didn't support targetPlatform aside from `universal (nix-prefetch-vscode-marketplace, nix-prefetch-openvsx: init at 0.1.0 #161369 (comment)), but such concern is now addressed by PR vscode-extensions.ms-vscode.cpptools: 1.9.1 -> 1.11.0 #178513.

// {
inherit vscodeExtPublisher vscodeExtName vscodeExtUniqueId;
};

inherit
configurePhase
Expand Down