{folly,fizz,mvfst,wangle,fbthrift,fb303,edencommon,watchman}: 2024.12.09.00 -> 2025.01.06.00, add patches for glog ≥ 0.7.0#371610
Conversation
emilazy
force-pushed
the
push-yzkmymulkkpq
branch
from
781d545 to
e9e5260
Compare
github-actions
bot
added
10.rebuild-darwin: 11-100
nix-owners
bot
requested review from
abbradar,
kylesferrazza,
pierreis,
risicle and
techknowlogick
|
|
||
| -find_package(Glog MODULE REQUIRED) | ||
| -include_directories(${GLOG_INCLUDE_DIR}) | ||
| +find_package(Glog CONFIG REQUIRED) |
There was a problem hiding this comment.
Probably worth making pull requests for those.
There was a problem hiding this comment.
They require signing a CLA and there’s an open Folly issue with a link to the AUR patch that they’ve completely ignored for half a year. These libraries are all thrown‐over‐the‐wall source dumps exported from Facebook’s monorepo that are a pain to build externally; their provided build scripts just download fixed versions of all their dependencies into place, so I’m not sure they care. Agreed that it would be nice for them to fix it upstream though and perhaps I’ll find the time to jump through all the hoops, but I just wanted to get thousands of builds unblocked on staging-next for now.
|
Sure, we can just merge both of the PRs together. |
paparodeo
left a comment
paparodeo
left a comment
There was a problem hiding this comment.
built watchman (which I think builds all of these pkgs) on x64 linux.
…6-05 Fixes gcc 14 build. Requires a new patch to fix the glog dependency, similar to those in NixOS#371610 (comment).
…6-05 Fixes gcc 14 build. Requires a new patch to fix the glog dependency, similar to those in NixOS#371610 (comment). (cherry picked from commit 473b372)
4 participants
Teaching Facebook to hold CMake correctly, one package at a time.
#349183 has more potential glog 0.7 fixes, though ideally things would be made to import the CMake targets correctly rather than just adding the
#define. I’ll investigate how many of those packages still need fixes. I haven’t picked thepkg-configchange so as to not throw away theglogbuild, and it seems like most users use it via CMake so hopefully it should be okay and we can follow upstream’s recommendation? But if there are any downstream packages usingpkg-configwe might have to work around it in those for now and adjust on the nextstagingcycle.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.