edencommon: skip flaky test on darwin#369477
Merged
emilazy merged 1 commit intoNixOS:staging-nextfrom Jan 8, 2025
Merged
Conversation
emilazy
requested changes
Dec 31, 2024
Member
emilazy
left a comment
There was a problem hiding this comment.
This would need sending to staging due to the Linux rebuilds. Those could be avoided with gross hacks but it’s probably not worth it.
Do we know for sure this is only flaky on Darwin? It might be worth just disabling unconditionally if not. (But I don’t mind just turning it off on Darwin and reassessing if it ends up failing on Linux too.)
13 tasks
emilazy
approved these changes
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #368745
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.