Skip to content

edencommon: skip flaky test on darwin#369477

Merged
emilazy merged 1 commit intoNixOS:staging-nextfrom
techknowlogick:eden-skip-test
Jan 8, 2025
Merged

edencommon: skip flaky test on darwin#369477
emilazy merged 1 commit intoNixOS:staging-nextfrom
techknowlogick:eden-skip-test

Conversation

@techknowlogick
Copy link
Member

Fix #368745

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Dec 30, 2024
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Dec 30, 2024
@ofborg ofborg bot requested a review from kylesferrazza December 31, 2024 06:27
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Dec 31, 2024
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would need sending to staging due to the Linux rebuilds. Those could be avoided with gross hacks but it’s probably not worth it.

Do we know for sure this is only flaky on Darwin? It might be worth just disabling unconditionally if not. (But I don’t mind just turning it off on Darwin and reassessing if it ends up failing on Linux too.)

@emilazy emilazy merged commit 60d28a0 into NixOS:staging-next Jan 8, 2025
9 of 13 checks passed
@techknowlogick techknowlogick deleted the eden-skip-test branch January 8, 2025 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(Flake) Build failure: edencommon (and therefore watchman) on arm64-darwin intermittently fails to build on master

2 participants