glog: disable broken test

[FliegendeWurst]

Full log: https://paste.fliegendewurst.eu/YLB4qa

ref. #205031

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Fits CONTRIBUTING.md.

[emilazy]

I think just unconditionally disabling the test would be better (as long as downstream packages do in fact work).

[FliegendeWurst]

It does look like it fails in library code: https://github.com/google/glog/blob/v0.7.1/src/logging.cc#L2236-L2340
Since the log stops after [ RUN ] EmailLogging.ValidAddress, which just goes straight to that function.

I am a bit confused no one else noticed the failure so far, since PIE is the default elsewhere..

[FliegendeWurst]

Now disabled unconditionally, after I observed a failure with PIE disabled

[FliegendeWurst]

Moved to staging-next, with an additional fix for missing libglog.pc. (Broke many downstream packages previously.)

[emilazy]

Broke many downstream packages previously.

Has this been seen in the current staging-next cycle? AFAICT the change in the original PR was purely prophylactic, and I suspect that the .pc might not work due to the same changes that have required CMake fixes in the Facebook packages. If we don’t have evidence of packages needing this I’d prefer to follow upstream and leave it out.

[FliegendeWurst]

I have evidence of at least one package that no longer works: the lomiri download manager.
https://paste.fliegendewurst.eu/4k9VYa.log

[FliegendeWurst]

By "previously" I just meant the state before this PR. The .pc file seems to work for the mentioned lomiri package.

[emilazy]

Does it actually build successfully with this change, given the #define that’s now required?

[FliegendeWurst]

glog builds, but the lomiri-download-manager does not. I'll drop the pkg-config changes then.

[emilazy]

Looks like you dropped the wrong commit.

[emilazy]

Looks good now, but will presumably have to go to the next staging cycle given the amount of rebuilds.

[FliegendeWurst]

For reference, here are the broken packages I found so far.

• lomiri-download-manager
• mir https://paste.fliegendewurst.eu/ZjLsaa.log
• trust-store

[emilazy]

Yeah. folly and friends were broken too. You can look at #371610 for how to patch downstream CMake files to hold glog correctly.

[OPNA2608]

For reference, here are the broken packages I found so far.

[Mir & Lomiri things]

Working on fixing these upstream & in Nixpkgs, feel free to ignore them.