wdt: 1.27.1612021-unstable-2024-12-06 -> 1.27.1612021-unstable-2025-06-05#416221
Merged
NickCao merged 1 commit intoNixOS:masterfrom Jun 12, 2025
Merged
wdt: 1.27.1612021-unstable-2024-12-06 -> 1.27.1612021-unstable-2025-06-05#416221NickCao merged 1 commit intoNixOS:masterfrom
NickCao merged 1 commit intoNixOS:masterfrom
Conversation
0128d1c to
b3152fc
Compare
…6-05 Fixes gcc 14 build. Requires a new patch to fix the glog dependency, similar to those in NixOS#371610 (comment).
NickCao
approved these changes
Jun 12, 2025
Member
NickCao
left a comment
There was a problem hiding this comment.
Diff: facebook/wdt@7e56c87...5cf3886
nixpkgs-review result
Generated using nixpkgs-review-gha
Command: nixpkgs-review pr 416221
Logs: https://github.com/NickCao/nixpkgs-review-gha/actions/runs/15621881632
x86_64-linux (sandbox = true)
✅ 1 package built:
- wdt
28 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gcc 14 build. (Tracking: #388196 #356812)
Requires a new patch to fix the glog dependency, similar to those in #371610 (comment).
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.