Skip to content

wdt: 1.27.1612021-unstable-2024-12-06 -> 1.27.1612021-unstable-2025-06-05#416221

Merged
NickCao merged 1 commit intoNixOS:masterfrom
mdaniels5757:update-wdt
Jun 12, 2025
Merged

wdt: 1.27.1612021-unstable-2024-12-06 -> 1.27.1612021-unstable-2025-06-05#416221
NickCao merged 1 commit intoNixOS:masterfrom
mdaniels5757:update-wdt

Conversation

@mdaniels5757
Copy link
Member

Fixes gcc 14 build. (Tracking: #388196 #356812)

Requires a new patch to fix the glog dependency, similar to those in #371610 (comment).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@mdaniels5757 mdaniels5757 force-pushed the update-wdt branch 2 times, most recently from 0128d1c to b3152fc Compare June 12, 2025 19:06
…6-05

Fixes gcc 14 build.

Requires a new patch to fix the glog dependency, similar to those in
NixOS#371610 (comment).
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 12, 2025
@nix-owners nix-owners bot requested a review from NickCao June 12, 2025 19:12
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff: facebook/wdt@7e56c87...5cf3886

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 416221

Logs: https://github.com/NickCao/nixpkgs-review-gha/actions/runs/15621881632


x86_64-linux (sandbox = true)

✅ 1 package built:
  • wdt

@NickCao NickCao merged commit 2847ee2 into NixOS:master Jun 12, 2025
15 of 18 checks passed
@mdaniels5757 mdaniels5757 deleted the update-wdt branch June 12, 2025 23:19
@mdaniels5757 mdaniels5757 added 9.needs: port to stable A PR needs a backport to the stable release. 8.has: port to stable This PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants