Skip to content

[Backport release-24.11] rustPlatform.fetchCargoVendor: init#362288

Merged
JohnRTitor merged 13 commits intorelease-24.11from
backport-349360-to-release-24.11
Dec 6, 2024
Merged

[Backport release-24.11] rustPlatform.fetchCargoVendor: init#362288
JohnRTitor merged 13 commits intorelease-24.11from
backport-349360-to-release-24.11

Conversation

@nixpkgs-ci
Copy link
Contributor

@nixpkgs-ci nixpkgs-ci bot commented Dec 6, 2024

Bot-based backport to release-24.11, triggered by a label in #349360.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Dec 6, 2024
13 tasks
@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 8.has: documentation This PR adds or changes documentation 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. labels Dec 6, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 6, 2024
@getchoo
Copy link
Member

getchoo commented Dec 6, 2024

@ofborg build cargo-shuttle hieroglypic popsicle python312Packages.json-stream-rs-tokenizer

tree_out_dir = out_dir / "git" / git_sha_rev
eprint(f"Fetching {url}#{git_sha_rev} -> git/{git_sha_rev}")

cmd = ["nix-prefetch-git", "--builder", "--quiet", "--url", url, "--rev", git_sha_rev, "--out", str(tree_out_dir)]

This comment was marked as resolved.

Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 362288


aarch64-linux

✅ 14 packages built:
  • cargo-shuttle
  • hieroglyphic
  • mitmproxy2swagger
  • mitmproxy2swagger.dist
  • nixpkgs-manual
  • popsicle
  • python311Packages.json-stream
  • python311Packages.json-stream-rs-tokenizer
  • python311Packages.json-stream-rs-tokenizer.dist
  • python311Packages.json-stream.dist
  • python312Packages.json-stream
  • python312Packages.json-stream-rs-tokenizer
  • python312Packages.json-stream-rs-tokenizer.dist
  • python312Packages.json-stream.dist

@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 6, 2024
@TomaSajt
Copy link
Contributor

TomaSajt commented Dec 6, 2024

I don't have anything against backporting.
But don't forget to backport the submodule fetching PR too!

@JohnRTitor JohnRTitor self-assigned this Dec 6, 2024
@JohnRTitor
Copy link
Member

JohnRTitor commented Dec 6, 2024

Let me just backport #356415 #356539 #357262 so that behaviour on unstable and release branch match (includes bugfixing commits)

EDIT: #357358 #359211 added too

@github-actions github-actions bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Dec 6, 2024
@github-actions github-actions bot added the 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. label Dec 6, 2024
@JohnRTitor JohnRTitor force-pushed the backport-349360-to-release-24.11 branch from e43f76f to 56125e2 Compare December 6, 2024 12:58
@JohnRTitor
Copy link
Member

Removed some fetchCargoVendor migration commits, they can be backported seperately if needed.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Dec 6, 2024
@JohnRTitor
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 362288


x86_64-linux

❌ 1 package failed to build:
  • nostui
✅ 14 packages built:
  • cargo-shuttle
  • hieroglyphic
  • mitmproxy2swagger
  • mitmproxy2swagger.dist
  • nixpkgs-manual
  • popsicle
  • python311Packages.json-stream
  • python311Packages.json-stream-rs-tokenizer
  • python311Packages.json-stream-rs-tokenizer.dist
  • python311Packages.json-stream.dist
  • python312Packages.json-stream
  • python312Packages.json-stream-rs-tokenizer
  • python312Packages.json-stream-rs-tokenizer.dist
  • python312Packages.json-stream.dist

(cherry picked from commit b859583)
@JohnRTitor
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 362288


x86_64-linux

✅ 14 packages built:
  • cargo-shuttle
  • hieroglyphic
  • mitmproxy2swagger
  • mitmproxy2swagger.dist
  • nixpkgs-manual
  • popsicle
  • python311Packages.json-stream
  • python311Packages.json-stream-rs-tokenizer
  • python311Packages.json-stream-rs-tokenizer.dist
  • python311Packages.json-stream.dist
  • python312Packages.json-stream
  • python312Packages.json-stream-rs-tokenizer
  • python312Packages.json-stream-rs-tokenizer.dist
  • python312Packages.json-stream.dist

Copy link
Member

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants