rustPlatform.fetchCargoVendor: fetch git submodules

[TomaSajt]

Related PR, where this issue was discovered: #356385

Looks like I missed that fetchgit has fetchSubmodules set to true by default, so when I was copying the importCargoLock implementation, I did not also fetch the submodules like (it turns out) it did.

fetchgit defaults:

nixpkgs/pkgs/build-support/fetchgit/default.nix

Lines 14 to 33 in 7b16c13

	{ url, rev ? "HEAD", leaveDotGit ? deepClone
	, outputHash ? lib.fakeHash, outputHashAlgo ? null
	, fetchSubmodules ? true, deepClone ? false
	, branchName ? null
	, sparseCheckout ? []
	, nonConeMode ? false
	, name ? urlToName url rev
	, # Shell code executed after the file has been fetched
	# successfully. This can do things like check or transform the file.
	postFetch ? ""
	, preferLocalBuild ? true
	, fetchLFS ? false
	, # Shell code to build a netrc file for BASIC auth
	netrcPhase ? null
	, # Impure env vars (https://nixos.org/nix/manual/#sec-advanced-attributes)
	# needed for netrcPhase
	netrcImpureEnvVars ? []
	, meta ? {}
	, allowedRequisites ? null
	}:

importCargoLock calling fetchgit:

nixpkgs/pkgs/build-support/rust/import-cargo-lock.nix

Lines 148 to 152 in 7b16c13

	fetchgit {
	inherit (gitParts) url;
	rev = gitParts.sha; # The commit SHA is always available.
	sha256 = gitShaOutputHash.${gitParts.sha};
	}

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[JohnRTitor]

Could you run a nixpkgs-review on this to see if the other packages using this fetcher have their hash changed?

[TomaSajt]

Checked all other uses of fetchCargoVendor:

nix-build --check -A cargo-shuttle.cargoDeps.vendorStaging -A hieroglyphic.cargoDeps.vendorStaging -A popsicle.cargoDeps.vendorStaging -A python312Packages.json-stream-rs-tokenizer.cargoDeps.vendorStaging

and their hash didn't change, so it seems like they don't use submodules

[TomaSajt]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 356415

---

x86_64-linux

✅ 14 packages built:

• cargo-shuttle
• cosmic-applets
• hieroglyphic
• mitmproxy2swagger
• mitmproxy2swagger.dist
• popsicle
• python311Packages.json-stream
• python311Packages.json-stream-rs-tokenizer
• python311Packages.json-stream-rs-tokenizer.dist
• python311Packages.json-stream.dist
• python312Packages.json-stream
• python312Packages.json-stream-rs-tokenizer
• python312Packages.json-stream-rs-tokenizer.dist
• python312Packages.json-stream.dist

[JohnRTitor]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 356415

---

x86_64-linux

✅ 14 packages built:

• cargo-shuttle
• cosmic-applets
• hieroglyphic
• mitmproxy2swagger
• mitmproxy2swagger.dist
• popsicle
• python311Packages.json-stream
• python311Packages.json-stream-rs-tokenizer
• python311Packages.json-stream-rs-tokenizer.dist
• python311Packages.json-stream.dist
• python312Packages.json-stream
• python312Packages.json-stream-rs-tokenizer
• python312Packages.json-stream-rs-tokenizer.dist
• python312Packages.json-stream.dist

[JohnRTitor]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 356415

---

aarch64-darwin

✅ 12 packages built:

• cargo-shuttle
• hieroglyphic
• mitmproxy2swagger
• mitmproxy2swagger.dist
• python311Packages.json-stream
• python311Packages.json-stream-rs-tokenizer
• python311Packages.json-stream-rs-tokenizer.dist
• python311Packages.json-stream.dist
• python312Packages.json-stream
• python312Packages.json-stream-rs-tokenizer
• python312Packages.json-stream-rs-tokenizer.dist
• python312Packages.json-stream.dist

[TomaSajt]

I'll merge this in an hour.

[JohnRTitor]

Sure, I was just waiting for eval.