Skip to content

[Backport release-24.11] qsv: 0.131.1 -> 0.138.0, build simplification#361116

Merged
wegank merged 3 commits intorelease-24.11from
backport-356504-to-release-24.11
Dec 6, 2024
Merged

[Backport release-24.11] qsv: 0.131.1 -> 0.138.0, build simplification#361116
wegank merged 3 commits intorelease-24.11from
backport-356504-to-release-24.11

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Dec 2, 2024

Bot-based backport to release-24.11, triggered by a label in #356504.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

@ofborg ofborg bot requested review from detroyejr and uncenter December 3, 2024 02:17
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 3, 2024
@wolfgangwalther
Copy link
Contributor

Result of nixpkgs-review pr 361116 run on x86_64-linux 1

1 package failed to build:
  • qsv

@wolfgangwalther wolfgangwalther marked this pull request as draft December 3, 2024 21:39
@detroyejr
Copy link
Contributor

My guess is this has to do with switching to useFetchCargoVendor and this or some other change in the rust tooling hasn't made it into to 24.11?

@wolfgangwalther
Copy link
Contributor

It says:

       > ERROR: The Cargo.lock contains git dependencies
       >
       > This is currently not supported in the fixed-output derivation fetcher.
       > Use cargoLock.lockFile / importCargoLock instead.

@detroyejr
Copy link
Contributor

The original PR for this on unstable builds fine though so I'm guessing this is an older version of the fetcher?

@wegank
Copy link
Member

wegank commented Dec 6, 2024

@ofborg build qsv qsv.passthru.tests

@wegank wegank marked this pull request as ready for review December 6, 2024 16:34
@wegank
Copy link
Member

wegank commented Dec 6, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 361116


aarch64-darwin

✅ 1 package built:
  • qsv

@wegank
Copy link
Member

wegank commented Dec 6, 2024

This now builds fine as #362288 is in, merging.

@wegank wegank merged commit ef08128 into release-24.11 Dec 6, 2024
@wegank wegank deleted the backport-356504-to-release-24.11 branch December 6, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants