cosmic-packages: move to new cargo fetcher#356539
Conversation
JohnRTitor
added
the
8.has: clean-up
|
a-kenji
left a comment
a-kenji
left a comment
There was a problem hiding this comment.
Thank you for splitting this in to reviewable chunks.
I have not tried every functionality of the packages in here, but ran every output against master to see if they match up.
For programs like cosmic-edit I tried them out manually.
|
@ofborg build cosmic-applibrary cosmic-bg cosmic-comp cosmic-design-demo cosmic-edit cosmic-files cosmic-greeter cosmic-launcher cosmic-notifications cosmic-osd cosmic-panel cosmic-randr cosmic-session cosmic-settings cosmic-settings-daemon cosmic-store cosmic-term cosmic-workspaces-epoch |
|
There still seems to be an issue with git fetching, maybe submodule related. You can see in the logs that the call to nix-prefetch-git caused the build faliure. Seeing a lot of http 403 codes. Originally git repos were fetched sequentially outside of the multiprocessing part. Maybe I should restore the logic to be like that. |
Perhaps it should respect EDIT: enableParallelBuilding may not mean parallelFetching, I suppose |
ofborg
bot
added
10.rebuild-darwin: 0
wegank
added
12.approved-by: package-maintainer
github-actions
bot
added
the
6.topic: rust
TomaSajt
force-pushed
the
cosmic-migrate-to-new-fetcher
branch
from
dbdafbd to
ff707e5
Compare
TomaSajt
force-pushed
the
cosmic-migrate-to-new-fetcher
branch
from
ff707e5 to
9fd5a8d
Compare
|
Okay, seems like decreasing the concurrency limit works for OfBorg. I didn't encounter issues locally, even when trying to build all cargoDeps at the same time. Opened a separate PR and cherry picked its commit into this PR. |
|
I also saw that #356743 added some retry logic, maybe that could also be incorporated later. |
|
@JohnRTitor does this change stop us from using nix-update to update our packaging? |
|
@ofborg build cosmic-applibrary cosmic-bg cosmic-comp cosmic-design-demo cosmic-edit cosmic-files cosmic-greeter cosmic-launcher cosmic-notifications cosmic-osd cosmic-panel cosmic-randr cosmic-session cosmic-settings cosmic-settings-daemon cosmic-store cosmic-term cosmic-workspaces-epoch |
|
It won't "stop" you, nix update just isn't compatible with it since it's a new fetcher. See Mic92/nix-update#298, adding support should be one PR away |
ofborg
bot
added
10.rebuild-darwin: 1-10
|
That tastes good :P
|
7 participants
Manually did it by hand. Though we should probably consider creating a script to get rid of other excess Cargo.locks.
Originally intended as part of #356385 but split to make reviews easier
CC: #327063
Closes #356821
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usageAdd a 👍 reaction to pull requests you find important.