Skip to content

joplin-desktop: revert addition of --enable-wayland-ime#411104

Merged
r-vdp merged 1 commit intoNixOS:masterfrom
AndrewKvalheim:joplin-desktop/revert-enable-wayland-ime
May 26, 2025
Merged

joplin-desktop: revert addition of --enable-wayland-ime#411104
r-vdp merged 1 commit intoNixOS:masterfrom
AndrewKvalheim:joplin-desktop/revert-enable-wayland-ime

Conversation

@AndrewKvalheim
Copy link
Member

With #358620 Joplin immediately crashes:

An error occurred: Unknown flag: --enable-wayland-ime=true

joplin_crash_dump_20250526T123057.json

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Resolves crash:

    Unknown flag: --enable-wayland-ime=true

Partially reverts NixOS#358620
@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label May 26, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 26, 2025
@nix-owners nix-owners bot requested review from HugoReeves, qjoly and yajo May 26, 2025 12:57
@r-vdp
Copy link
Contributor

r-vdp commented May 26, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 411104
Commit: 838dcf19592843529278158f95801b87142573a7


x86_64-linux

✅ 1 package built:
  • joplin-desktop

@r-vdp r-vdp merged commit c18ed75 into NixOS:master May 26, 2025
13 of 14 checks passed
HHR2020 added a commit to HHR2020/nixpkgs that referenced this pull request May 29, 2025
fix input method when NIXOS_OZONE_WL is set

reverts NixOS#411104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. ofborg-internal-error Ofborg encountered an error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants