Skip to content

zettlr: 3.2.0 -> 3.3.1 and make it possible to take commandLineArgs#357759

Closed
kachick wants to merge 3 commits intoNixOS:masterfrom
kachick:update-zettlr
Closed

zettlr: 3.2.0 -> 3.3.1 and make it possible to take commandLineArgs#357759
kachick wants to merge 3 commits intoNixOS:masterfrom
kachick:update-zettlr

Conversation

@kachick
Copy link
Member

@kachick kachick commented Nov 21, 2024

Changes: Zettlr/Zettlr@v3.2.0...v3.3.1

I wish to use this version or later because it includes updating for Electron 33.
So adding --enable-wayland-ime --wayland-text-input-version=3 makes it possible to use IME on Wayland. electron/electron#33662 (comment)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@kachick

This comment was marked as outdated.

@kachick kachick requested review from ryand56 and tfmoraes November 21, 2024 04:36
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 22, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 22, 2024
@kachick

This comment was marked as resolved.

@github-actions github-actions bot removed the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Dec 4, 2024
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 4, 2024
@kachick

This comment was marked as resolved.

@kachick
Copy link
Member Author

kachick commented Dec 5, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 357759


x86_64-linux

✅ 1 package built:
  • zettlr

x86_64-darwin


aarch64-darwin

@ofborg ofborg bot added the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Dec 5, 2024
@kachick
Copy link
Member Author

kachick commented Dec 24, 2024

I may not have enough bandwidth to address these changes, so closing now. Thanks for reviewing. 🙏

@kachick kachick closed this Dec 24, 2024
@kachick kachick deleted the update-zettlr branch December 24, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants