various: fix build with GCC 14 by FliegendeWurst · Pull Request #357774 · NixOS/nixpkgs

FliegendeWurst · 2024-11-21T07:11:43Z

Regression from #356812

Things done

Built on platform(s)
- x86_64-linux
Fits CONTRIBUTING.md.

emilazy · 2024-11-21T17:31:36Z

Can you please check any of these packages can be updated to a new upstream release, or else patched with an upstream change or patch from another GCC 14 distro (e.g. Arch), before we resort to turning off the warnings?

FliegendeWurst · 2024-11-21T20:10:22Z

shapely: Fix incompatible pointer type passed to GEOSPolygonize_r shapely/shapely#1945
perl DBD mysql has newer version, but those are not compatible with our libmysqlclient
xmlsec: 1.3.14: build fails with -Wincompatible-pointer-types xmlsec/python-xmlsec#323
systemtap has a newer version
cdrtools was moved to http://sf.net/projects/schilytools/files/ (which contains a lot more stuff too)
cdrkit: cdrkit: source disappeared #357975
freerdp: has patches

I will push as soon as it finishes building.

emilazy · 2024-11-21T20:23:04Z

Thank you!

linuxPackages.systemtap: 5.0a -> 5.2; libsystemtap: 5.1 -> 5.2 #357981 is currently building the tests on the community builder for SystemTap.
Can we bump libmysqlclient? It’s very early in the release cycle.
The cdrtools author passed away; I believe https://codeberg.org/schilytools/schilytools is a maintained fork. However it has a somewhat controversial and iffy licensing situation; IIRC we have a bunch of stuff depending on it that probably ought not to. @fabianhjr do I recall correctly that you had a PR to remove at least one use of it?
cdrkit (a fork of cdrtools before its licence changed) is dead. A lot of distributions package it, however; perhaps Debian or Fedora or Gentoo might have a patch?

FliegendeWurst · 2024-11-21T20:24:54Z

Regarding libmysqlclient: @globin, is there a newer version available?

FliegendeWurst · 2024-11-21T20:30:03Z

Debian has a patch for cdrkit: https://sources.debian.org/patches/cdrkit/9:1.1.11-3.5/fix-implicit-function-declaration.patch/
I'll include it.

emilazy · 2024-11-21T21:13:10Z

Yay. I’d recommend getting it from their Salsa GitLab which IIRC has stabler URLs. Or maybe we should just fetch the whole thing from Salsa, since Debian were basically always the upstream anyway and the actual tarball is gone.

Then we could apply the entire patchset; see e.g. #354257.

fabianhjr · 2024-11-21T22:42:31Z

The cdrtools author passed away; I believe https://codeberg.org/schilytools/schilytools is a maintained fork. However it has a somewhat controversial and iffy licensing situation; IIRC we have a bunch of stuff depending on it that probably ought not to. @fabianhjr do I recall correctly that you had a PR to remove at least one use of it?

If I remember correctly I changed rhythmbox from brasero to brasero-unwrapped. (Which doesn't depend on cdrtools but brasero wraped does)

EDIT: #345381

emilazy

LGTM except for one file and the DBD thing which I’d prefer to omit for now in hopes of finding a better solution.

pkgs/development/python-modules/shapely/default.nix

FliegendeWurst · 2024-11-23T09:41:03Z

DBD thing which I’d prefer to omit for now in hopes of finding a better solution.

Unfortunately that perl module is used by mariadb-server -> akonadi -> default Plasma setup. So I don't see a much better solution.

emilazy · 2024-11-23T17:19:25Z

Unfortunately that perl module is used by mariadb-server -> akonadi -> default Plasma setup. So I don't see a much better solution.

The rest of the changes seem good, but I would prefer to see if we can solve the libmysqlclient issue before resigning ourselves to simply pinning an old broken version of a Perl package forever. We have over a week and probably multiple until staging-next, there’s no rush.

emilazy · 2024-11-24T02:48:15Z

@Aleksanaa BTW, I believe that “various:” was more accurate than “treewide:” in this case – there’s no way this PR is going to fix all GCC 14 regressions across the tree (and we unnecessarily conflate changes that touch multiple packages with actual treewides, which has lead to miscommunications in the past).

emilazy · 2024-11-24T23:11:00Z

pkgs/top-level/perl-packages.nix

+    nativeBuildInputs = [
+      pkgs.mysql80 # for mysql_config
+    ];
+    buildInputs = [
+      DevelChecklib
+      TestDeep
+      TestDistManifest
+      TestPod
+      pkgs.libmysqlconnectorcpp
+      pkgs.libxcrypt
+      pkgs.openssl
+      pkgs.zstd
+    ];


So, I forget the details of the MySQL/MariaDB split, but: previously we were using libmysqlclient, which is actually mariadb-connector-c. Now we’re pulling in an entire build of actual MySQL and libmysqlconnectorcpp which also seems to be a MySQL thing. I’m not saying this is necessarily a problem but I want to make sure we want to include MySQL in the default desktop closure, and indeed the closure of mariadb-server itself?

There’s also DBD::MariaDB – I don’t know if it’s compatible with mytop or not, but maybe we should be using that instead? cc @Conni2461 @dasJ

I think it is needed for mytop.sh and https://github.com/MariaDB/server/blob/eff9c198e32a828f610b93fad3a0f0eb63b3ded2/scripts/mytop.sh#L250-L255 seems to show that it is fine with MariaDB connector

I can switch it over, but not really test it.

Switching it over seems like the best idea. I think that we don’t want the MySQL server in the MariaDB server’s build closure, and probably don’t want MySQL stuff in the desktop closure at all :)

Of course I’m assuming that DBD::MariaDB builds…

it builds. I switched it over a a few days ago when building but thought that mytop.sh only supported the mysql version so didn't move forward -- looking over it again I misread the mytop.sh code, but like @FliegendeWurst implies, testing that it works is the hard part.

It would be sort of embarrassing if MariaDB were shipping a script that purported to support MariaDB but that actually required MySQL to build, I think. It doesn’t look like the script is doing anything fancy with the connection. I’d be comfortable switching to unbreak it.

assuming the DBDMariaDB perl package works, I agree. the diff is pretty straightforward.

diff --git a/pkgs/servers/sql/mariadb/default.nix b/pkgs/servers/sql/mariadb/default.nix index a178e1fa28e4..921510a07f91 100644 --- a/pkgs/servers/sql/mariadb/default.nix +++ b/pkgs/servers/sql/mariadb/default.nix @@ -26,7 +26,7 @@ let libExt = stdenv.hostPlatform.extensions.sharedLibrary; - mytopEnv = buildPackages.perl.withPackages (p: with p; [ DBDmysql DBI TermReadKey ]); + mytopEnv = buildPackages.perl.withPackages (p: with p; [ DBDMariaDB DBI TermReadKey ]); common = rec { # attributes common to both builds inherit version;

emilazy · 2024-11-24T23:11:17Z

pkgs/tools/cd-dvd/cdrtools/default.nix

+  env.CFLAGS = toString [
+    "-Wno-error=implicit-int"
+    "-Wno-error=implicit-function-declaration"
+  ];


Non‐blocking nit: lib.concatStringsSep " " has less surprising behaviour in general (but they are equivalent in this case).

emilazy

Looks great now, thank you!

github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Nov 21, 2024

FliegendeWurst changed the title ~~python312Packages.shapely: fix build with GCC 14~~ various: fix build with GCC 14 Nov 21, 2024

fabianhjr approved these changes Nov 21, 2024

View reviewed changes

nix-owners bot requested review from marcusramberg, stigtsp and zakame November 21, 2024 07:22

FliegendeWurst force-pushed the shapely-gcc14 branch 2 times, most recently from 6cfe17f to 235fcd1 Compare November 21, 2024 13:05

FliegendeWurst force-pushed the shapely-gcc14 branch from 235fcd1 to 3dec831 Compare November 21, 2024 21:22

FliegendeWurst mentioned this pull request Nov 21, 2024

cdrkit: source disappeared #357975

Closed

FliegendeWurst force-pushed the shapely-gcc14 branch from 3dec831 to 0b6678c Compare November 21, 2024 22:01

Aleksanaa changed the title ~~various: fix build with GCC 14~~ treewide: fix build with GCC 14 Nov 22, 2024

FliegendeWurst force-pushed the shapely-gcc14 branch from fc042f3 to 819d1bb Compare November 22, 2024 18:38

ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Nov 22, 2024

emilazy requested changes Nov 23, 2024

View reviewed changes

pkgs/development/python-modules/shapely/default.nix Outdated Show resolved Hide resolved

FliegendeWurst force-pushed the shapely-gcc14 branch from 819d1bb to aa18db4 Compare November 23, 2024 09:41

Aleksanaa changed the title ~~treewide: fix build with GCC 14~~ various: fix build with GCC 14 Nov 24, 2024

FliegendeWurst added 2 commits November 24, 2024 18:24

python312Packages.shapely: fix build with GCC 14

54601fd

python312Packages.xmlsec: fix build with GCC 14

57f6fd6

FliegendeWurst added 4 commits November 24, 2024 18:24

cdrtools: fix build with GCC 14

c4f27b6

cdrkit: move to debian source, apply debian patches

11787cb

freerdp: fix build with GCC 14

f75b34c

perlPackages.DBDmysql: 4.050 -> 5.010

6dcdf8a

FliegendeWurst force-pushed the shapely-gcc14 branch from aa18db4 to 6dcdf8a Compare November 24, 2024 17:26

emilazy reviewed Nov 24, 2024

View reviewed changes

mariadb-server: use DBDMariaDB insteady of mysql

9f6ea15

emilazy approved these changes Nov 25, 2024

View reviewed changes

emilazy merged commit bf1a2b2 into NixOS:staging Nov 25, 2024

Sigmanificient mentioned this pull request Mar 8, 2025

Tracking: package failing with GCC 14 #388196

Open

28 tasks

Moredread mentioned this pull request Aug 24, 2025

s-tar: force '-std=c89' so it builds with recent compilers #436514

Merged

13 tasks

Uh oh!

Conversation

FliegendeWurst commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Things done

Uh oh!

emilazy commented Nov 21, 2024

Uh oh!

FliegendeWurst commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

emilazy commented Nov 21, 2024

Uh oh!

FliegendeWurst commented Nov 21, 2024

Uh oh!

FliegendeWurst commented Nov 21, 2024

Uh oh!

emilazy commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabianhjr commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

emilazy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

FliegendeWurst commented Nov 23, 2024

Uh oh!

emilazy commented Nov 23, 2024

Uh oh!

emilazy commented Nov 24, 2024

Uh oh!

emilazy Nov 24, 2024

Choose a reason for hiding this comment

Uh oh!

paparodeo Nov 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FliegendeWurst Nov 24, 2024

Choose a reason for hiding this comment

Uh oh!

emilazy Nov 24, 2024

Choose a reason for hiding this comment

Uh oh!

paparodeo Nov 25, 2024

Choose a reason for hiding this comment

Uh oh!

emilazy Nov 25, 2024

Choose a reason for hiding this comment

Uh oh!

paparodeo Nov 25, 2024

Choose a reason for hiding this comment

Uh oh!

emilazy Nov 24, 2024

Choose a reason for hiding this comment

Uh oh!

emilazy left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

FliegendeWurst commented Nov 21, 2024 •

edited

Loading

FliegendeWurst commented Nov 21, 2024 •

edited

Loading

emilazy commented Nov 21, 2024 •

edited

Loading

fabianhjr commented Nov 21, 2024 •

edited

Loading

paparodeo Nov 24, 2024 •

edited

Loading