Skip to content

linuxPackages.systemtap: 5.0a -> 5.2; libsystemtap: 5.1 -> 5.2#357981

Merged
emilazy merged 2 commits intoNixOS:stagingfrom
emilazy:push-nvpzpqzqvxpq
Nov 21, 2024
Merged

linuxPackages.systemtap: 5.0a -> 5.2; libsystemtap: 5.1 -> 5.2#357981
emilazy merged 2 commits intoNixOS:stagingfrom
emilazy:push-nvpzpqzqvxpq

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Nov 21, 2024

Includes fixes for GCC 14.

In the process of building the test.

cc @FliegendeWurst

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Includes fixes for GCC 14.
@FliegendeWurst
Copy link
Member

The withStap = false version already built successfully for me.

@emilazy emilazy mentioned this pull request Nov 21, 2024
2 tasks
@emilazy
Copy link
Member Author

emilazy commented Nov 21, 2024

Yeah, I checked the first build with GCC 14 but I’m building the tests on top of master just to make sure the new version doesn’t break anything.

@emilazy
Copy link
Member Author

emilazy commented Nov 21, 2024

Why is libsystemtap an entirely separate derivation on a different version…

@emilazy emilazy changed the title linuxPackages.systemtap: 5.0a -> 5.2 linuxPackages.systemtap: 5.0a -> 5.2; libsystemtap: 5.1 -> 5.2 Nov 21, 2024
@emilazy emilazy marked this pull request as ready for review November 21, 2024 21:14
@emilazy
Copy link
Member Author

emilazy commented Nov 21, 2024

The test passes with a master base; good enough for me.

@emilazy emilazy merged commit ad9b81e into NixOS:staging Nov 21, 2024
@emilazy emilazy deleted the push-nvpzpqzqvxpq branch November 21, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants