Skip to content

s-tar: force '-std=c89' so it builds with recent compilers#436514

Merged
pyrox0 merged 1 commit intoNixOS:masterfrom
Moredread:s-tar-std89
Sep 5, 2025
Merged

s-tar: force '-std=c89' so it builds with recent compilers#436514
pyrox0 merged 1 commit intoNixOS:masterfrom
Moredread:s-tar-std89

Conversation

@Moredread
Copy link
Contributor

@Moredread Moredread commented Aug 24, 2025

s-tar hasn't been building since the end of 2024, due to (I guess) a gcc update, that errors on more warnings. As star seems to target the old C standard, we enforce building it with -std=c89.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 24, 2025
@nix-owners nix-owners bot requested a review from wucke13 August 24, 2025 16:11
@nixpkgs-ci nixpkgs-ci bot added 9.needs: reviewer This PR currently has no reviewers requested and needs attention. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Aug 24, 2025
@Moredread
Copy link
Contributor Author

PR #357774 and #304628 are related to this, but I think we should fix this derivation, while the other PRs are still worked on.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Aug 24, 2025
@pyrox0 pyrox0 merged commit 20481fc into NixOS:master Sep 5, 2025
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants