Skip to content

ccze: 0.2.1-2 -> 0.2.1-8, move to by-name#354257

Merged
philiptaron merged 2 commits intoNixOS:masterfrom
philiptaron:ccze
Nov 19, 2024
Merged

ccze: 0.2.1-2 -> 0.2.1-8, move to by-name#354257
philiptaron merged 2 commits intoNixOS:masterfrom
philiptaron:ccze

Conversation

@philiptaron
Copy link
Contributor

The only maintained source for this package appears to be Debian.

https://salsa.debian.org/debian/ccze/-/raw/master/debian/changelog?ref_type=heads

I moved it to pkgs/by-name in addition to the update, and added myself as a maintainer. cc @malyn.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@philiptaron philiptaron requested a review from malyn November 7, 2024 16:15
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 7, 2024
@Pandapip1 Pandapip1 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 9, 2024
@Pandapip1
Copy link
Member

Pandapip1 commented Nov 9, 2024

Merge conflict due to #354531.

@wegank wegank removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 10, 2024
Debian appears to be the only maintained source for this package.
Added a changelog and a mainProgram.
Copy link
Contributor

@nim65s nim65s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff lgtm.
binary works with eg cat whatever | nix run .#ccze
nixpkgs-review is also fine:

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 354257


x86_64-linux

✅ 3 packages built:
  • airgeddon
  • ccze
  • hollywood

aarch64-darwin

@philiptaron philiptaron merged commit b5b85d0 into NixOS:master Nov 19, 2024
@philiptaron philiptaron deleted the ccze branch November 19, 2024 17:16
@emilazy emilazy mentioned this pull request Nov 21, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants