virtualbox: do not use open-watcom-bin#352610
Merged
emilazy merged 1 commit intoNixOS:masterfrom Oct 31, 2024
Merged
Conversation
Contributor
Author
|
Closing in favour of #352609 |
Member
|
We should still do both, as Open Watcom has licensing issues. |
13 tasks
Member
|
I’ve merged the other fix, but it’d be good to get this in since otherwise #352608 will stop VirtualBox and the OVA being built on Hydra. |
emilazy
approved these changes
Oct 31, 2024
Member
emilazy
left a comment
There was a problem hiding this comment.
Successfully built on x86_64-linux, thanks! Having to use pre‐built assembly sources is a bit unfortunate, but better than depending on a non‐Free compiler that we get as a binary blob.
BTW, it seems the meta.license is out of date – they’ve moved to GPL 3 with a linking exception for GPL 2 (sadly something we lack an elegant way of representing).
13 tasks
13 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hopefully fixing: #351413
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.