open-watcom-bin: do an unattended instead of a scripted install#352609
Merged
emilazy merged 1 commit intoNixOS:masterfrom Oct 31, 2024
Merged
open-watcom-bin: do an unattended instead of a scripted install#352609emilazy merged 1 commit intoNixOS:masterfrom
emilazy merged 1 commit intoNixOS:masterfrom
Conversation
13 tasks
Member
|
Thanks. We would like to stop using Open Watcom in this package as it has a flaky QEMU‐based build and a problematic licence. Will this work together with #352610 to use the pre‐generated assembly sources or will they need work to combine? Edit: Sorry, I misread this PR as applying to the VirtualBox package… These changes LGTM. |
emilazy
approved these changes
Oct 31, 2024
Member
emilazy
left a comment
There was a problem hiding this comment.
Built successfully on x86_64-linux, and seems a lot simpler than using expect.
Contributor
|
@skeuchel Thanks for fixing this! Btw, we can probably do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
open-watcom-binpackage is installed via the original command line installer. So far anexpectscript interacts with the installer to make the appropriate choices. This PR replaces this with an unattended install that provides the settings on the command line instead.Fixes #351413.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.