virtualbox: restore ability to build with Open Watcom (off by default)#352914
Merged
emilazy merged 3 commits intoNixOS:masterfrom Nov 1, 2024
Merged
virtualbox: restore ability to build with Open Watcom (off by default)#352914emilazy merged 3 commits intoNixOS:masterfrom
emilazy merged 3 commits intoNixOS:masterfrom
Conversation
This reverts commit 67aa62d.
... to avoid depending on open-watcom-bin which has a habit of breaking.
blitz
force-pushed
the
open-watcom-repair
branch
from
49c09d3 to
8604b68
Compare
blitz
force-pushed
the
open-watcom-repair
branch
from
8604b68 to
78ebb34
Compare
emilazy
approved these changes
Nov 1, 2024
Member
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
Sure, why not. I’m curious, do you actually patch these BIOS files?
Contributor
Author
|
Result of 1 package marked as broken and skipped:
25 packages built:
|
Contributor
Author
We had to do this in the past, yes. It's also interesting for people who want to build everything from source, because the "alternative BIOS sources" are pre-compiled C code which feels a bit like shipping binaries. :) |
Member
|
Well… yeah, but the compiler we’re using to build them is itself sourced from binaries, hence the package name, so I don’t think it’s really any better from a bootstrapping perspective :) Still, fine to have this if it’s useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert #352610 and replace it with a simpler mechanism that doesn't remove the ability to build the BIOS sources with Open Watcom. Being able to build the BIOS sources is important, because otherwise there is no sane of patching them. But I agree that we don't need to pull in Open Watcom for the default build.
While I was here I also fixed the
virtualboxKvmbuild for 7.0.22.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.