Skip to content

virtualbox/virtualboxGuestAdditions: update/fix license to gpl3Only#352640

Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom
FriedrichAltheide:virtualbox-license
Apr 29, 2025
Merged

virtualbox/virtualboxGuestAdditions: update/fix license to gpl3Only#352640
GaetanLepage merged 1 commit intoNixOS:masterfrom
FriedrichAltheide:virtualbox-license

Conversation

@FriedrichAltheide
Copy link
Copy Markdown
Contributor

@FriedrichAltheide FriedrichAltheide commented Oct 31, 2024 •
edited
Loading

https://www.virtualbox.org/wiki/Download_Old_Builds_7_0
https://www.virtualbox.org/wiki/Licensing_FAQ

#352610 (review)
@emilazy

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

emilazy
emilazy previously requested changes Oct 31, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be gpl3Only (gpl3 is deprecated in favour of that and gpl3Plus), and it’d be good to add a comment about the GPLv2 linking exception and linking to the appropriate file, since it’s not quite regular GPLv3.

@FriedrichAltheide FriedrichAltheide changed the title virtualbox/virtualboxGuestAdditions: update/fix license to gpl3 virtualbox/virtualboxGuestAdditions: update/fix license to gpl3Only Oct 31, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 31, 2024
@Pandapip1 Pandapip1 added the 1.severity: legal This PR or issue raises or fixes a legal issue, e.g. licensing compliance label Nov 6, 2024
@l0b0 l0b0 requested a review from emilazy November 26, 2024 03:47
@emilazy
Copy link
Copy Markdown
Member

emilazy commented Nov 26, 2024

Still needs a comment clarifying that this isn’t actually quite gpl3Only.

@FriedrichAltheide
Copy link
Copy Markdown
Contributor Author

FriedrichAltheide commented Dec 17, 2024

I'm not quite sure how detailed this comment should be. One option would be just to point out that it is not a pure gplv3. Or you could include the entire preliminary notes.

@ck3d
Copy link
Copy Markdown
Contributor

ck3d commented Jan 2, 2025

I would switch to gpl3Only, since it is less wrong than gpl2

@FriedrichAltheide
Copy link
Copy Markdown
Contributor Author

FriedrichAltheide commented Jan 23, 2025

@emilazy ping

@FriedrichAltheide
Copy link
Copy Markdown
Contributor Author

FriedrichAltheide commented Jan 31, 2025

@emilazy ping
@blitz

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 17, 2025
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Feb 28, 2025
@FriedrichAltheide FriedrichAltheide mentioned this pull request Apr 29, 2025
Merged
13 tasks
@FriedrichAltheide
Copy link
Copy Markdown
Contributor Author

FriedrichAltheide commented Apr 29, 2025

ping

@FriedrichAltheide FriedrichAltheide added the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. label Apr 29, 2025
@GaetanLepage GaetanLepage merged commit 67b1c0d into NixOS:master Apr 29, 2025
2 checks passed
@nixpkgs-ci
Copy link
Copy Markdown
Contributor

nixpkgs-ci bot commented Apr 29, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Apr 29, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xanderio xanderio xanderio approved these changes

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@emilazy emilazy Awaiting requested review from emilazy

+2 more reviewers

@blitz blitz blitz approved these changes

@snue snue snue approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

1.severity: legal This PR or issue raises or fixes a legal issue, e.g. licensing compliance 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@FriedrichAltheide @emilazy @ck3d @blitz @xanderio @snue @GaetanLepage @wegank @Pandapip1