luaPackages/vimPlugins: update on 2024-09-16#342196
Merged
GaetanLepage merged 4 commits intoNixOS:masterfrom Sep 20, 2024
Merged
luaPackages/vimPlugins: update on 2024-09-16#342196GaetanLepage merged 4 commits intoNixOS:masterfrom
GaetanLepage merged 4 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: lua
khaneliman
changed the title
Contributor
Author
|
Result of 25 packages marked as broken and skipped:
10 packages failed to build:
379 packages built:
|
ofborg
bot
requested review from
Mephistophiles,
Shados,
mrcjkb,
natsukium,
teto and
vcunat
ofborg
bot
added
10.rebuild-darwin: 101-500
ofborg
bot
added
8.has: clean-up
Contributor
Author
|
Result of 25 packages marked as broken and skipped:
383 packages built:
|
Contributor
Author
|
Result of 24 packages marked as broken and skipped:
4 packages failed to build:
370 packages built:
|
Contributor
Author
|
Rest-nvim works for me |
Contributor
Author
|
@PerchunPak what was the plenary regression you tested before? |
Member
|
🤔 what's the build output of |
Contributor
Author
I get local failures from tests, @GaetanLepage and hydra don't seem to get them #341146 (comment) |
Member
|
As it's Darwin, could it be related to sandboxing in your nix config (see the issue template check list)? |
Contributor
Author
Yeah, darwin sandbox support is terrible... I can't enable it in my config due to serialization errors and nixpkgs-review doesn't allow sandbox command on darwin. |
Contributor
|
Result of 30 packages marked as broken and skipped:
376 packages built:
|
Contributor
|
|
Contributor
|
Result of 29 packages marked as broken and skipped:
7 packages failed to build:
356 packages built:
|
PerchunPak
suggested changes
Sep 18, 2024
PerchunPak
approved these changes
Sep 19, 2024
Member
PerchunPak
left a comment
PerchunPak
left a comment
There was a problem hiding this comment.
If nixpkgs-review passes, LGTM
Contributor
Author
|
Result of 28 packages marked as broken and skipped:
374 packages built:
|
wegank
added
the
12.approvals: 1
Contributor
|
Result of 28 packages marked as broken and skipped:
5 packages failed to build:
356 packages built:
|
Contributor
We still have some failures on darwin unfortunately. Logs ( |
Member
|
How about we disable checks for |
Contributor
Sure, good idea. |
Contributor
Author
|
Result of 22 packages marked as broken and skipped:
374 packages built:
|
Contributor
Author
|
Result of 21 packages marked as broken and skipped:
374 packages built:
|
Contributor
Author
|
Failures I saw were due to already broken dependencies on master. Result of 21 packages marked as broken and skipped:
9 packages failed to build:
365 packages built:
|
GaetanLepage
approved these changes
Sep 20, 2024
Contributor
GaetanLepage
left a comment
GaetanLepage
left a comment
There was a problem hiding this comment.
Thanks for this nice effort @khaneliman !
Contributor
|
This PR renamed render-markdown-nvim to render-markdown because the script was run before #340286 was merged. Shuold I fix it with a PR? Or you will run the script soon? |
Contributor
|
Yes indeed, I am working on it in #343557. |
Member
|
FYI, this merge broke |
Merged
13 tasks
Contributor
Author
Thanks, looks like we coded a check for a dependency that was removed with the rest.nvim bump. will update soon. |
Merged
13 tasks
khaneliman
added a commit
to khaneliman/nixpkgs
that referenced
this pull request
Mar 15, 2025
Dependencies changed in NixOS#342196
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Updating both the luaPackages and the vimPlugins together so they can stay in sync.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.