Skip to content

luajit_2_0: 2.0.1713483859 -> 2.0.1741557863; luajit_2_1: 2.1.1713773202 -> 2.1.1741730670#389321

Merged
vcunat merged 2 commits intoNixOS:staging-nextfrom
khaneliman:luajit-update
Mar 17, 2025
Merged

luajit_2_0: 2.0.1713483859 -> 2.0.1741557863; luajit_2_1: 2.1.1713773202 -> 2.1.1741730670#389321
vcunat merged 2 commits intoNixOS:staging-nextfrom
khaneliman:luajit-update

Conversation

@khaneliman
Copy link
Contributor

@khaneliman khaneliman commented Mar 12, 2025 •
edited by vcunat
Loading

Things done

Just been testing with neovim.

Luajit_2_1: LuaJIT/LuaJIT@5790d25...538a821
Luajit_2_0:LuaJIT/LuaJIT@9b5e837...85c3f2f

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. label Mar 12, 2025
khaneliman added a commit to khaneliman/khanelivim that referenced this pull request Mar 12, 2025
@khaneliman
overlays/luajit: bump to latest
c82986c 
Until NixOS/nixpkgs#389321 makes it to master
@github-actions github-actions bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Mar 12, 2025
@khaneliman
Copy link
Contributor Author

khaneliman commented Mar 12, 2025 •
edited
Loading

Not sure if this still needs to go through staging now that we aren't building vimPlugins on hydra... rebuild count looks a lot lower than last bump #312963 @vcunat or should we still go this route?

@khaneliman khaneliman requested a review from a team March 14, 2025 17:37
@vcunat
Copy link
Member

vcunat commented Mar 15, 2025

That CI has been broken for a long time:
#342196 (comment)

@vcunat vcunat changed the base branch from staging to staging-next March 15, 2025 11:36
@vcunat
Copy link
Member

vcunat commented Mar 15, 2025

Given that this doesn't seem urgent, let's go with staging-next as a compromise. All other .tests pass for me on x86_64 NixOS, and it looks good overall.

@khaneliman
Copy link
Contributor Author

khaneliman commented Mar 15, 2025

Sounds good, updated test in #390140

@vcunat
Copy link
Member

vcunat commented Mar 17, 2025

Just rebased to let CI test it better.

@vcunat vcunat merged commit 5d3dce1 into NixOS:staging-next Mar 17, 2025
25 of 27 checks passed
@khaneliman khaneliman deleted the luajit-update branch March 17, 2025 12:31
@trofi
Copy link
Contributor

trofi commented Mar 18, 2025

naev regressed the build. Proposed the fix as:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@khaneliman @vcunat @trofi