vimPlugins.render-markdown-nvim: add nvim-treesitter dependency#343557
vimPlugins.render-markdown-nvim: add nvim-treesitter dependency#343557Aleksanaa merged 2 commits intoNixOS:masterfrom
Conversation
336083f to
fb384a8
Compare
|
Result of 2 packages built:
|
|
it should not be too hard to test the plugin. add the dependencies into RTP (since nixpkgs infra doesn't do that yet) , open a markdown and see if if neovim errors out. like Some tests are visible for reference at |
There was a problem hiding this comment.
nvimRequireCheck = "render-markdown"?
fb384a8 to
0ed2854
Compare
This didn't make it to the PR in the end. |
|
This is one of those cases where the plugin doesn't actually depend on nvim-treesitter, but it requires one or multiple parsers to be installed. In such cases, adding nvim-treesitter as a dependency won't make the plugin work out of the box. Users will still have to specify |
Right, I forgot about this. I will revert it to prevent such noise from remaining in the code base. |
Description of changes
From their README
it seems that treesitter is required.
The rest look like optional dependencies.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.