vimPlugins: update on 2024-09-11#341146
Merged
GaetanLepage merged 5 commits intoNixOS:masterfrom Sep 12, 2024
Merged
Conversation
khaneliman
force-pushed
the
vim
branch
2 times, most recently
from
fb40f73 to
a8e1e52
Compare
Contributor
Author
|
Result of 6 packages marked as broken and skipped:
1 package failed to build:
443 packages built:
|
PerchunPak
suggested changes
Sep 11, 2024
Member
PerchunPak
left a comment
PerchunPak
left a comment
There was a problem hiding this comment.
Nice, I just was going to create an update. Could you please implement what I wrote in #337299?
Contributor
|
Thank you for rolling this update. |
Member
|
Better to just manually revert its update. I don't think luaPackages update is too far away |
Contributor
Yes, this is what I meant but poorly phrased. |
Contributor
Author
Didn't realize that's why it was held back, sure I'll undo that bump. |
Contributor
Author
|
Result of 6 packages marked as broken and skipped:
444 packages built:
|
Member
|
Result of 6 packages marked as broken and skipped:
1 package failed to build:
442 packages built:
|
Contributor
Author
I'm seeing similar issue with neotest on aar64-darwin, i think with tests. Running the nixpkgs-review again one more time just to validate it's not transient errors. |
Contributor
Author
|
Nevermind, it was sqlite errors. Result of 6 packages marked as broken and skipped:
5 packages failed to build:
439 packages built:
Hash mismatch on treesitter sql grammar on darwin somehow... |
Contributor
Author
|
Result of 6 packages marked as broken and skipped:
4 packages failed to build:
439 packages built:
|
Contributor
Author
|
Result of 6 packages marked as broken and skipped:
443 packages built:
|
Member
|
Could you post logs for |
Contributor
Author
Member
|
Found why tests in neotest fail nixpkgs/pkgs/development/lua-modules/overrides.nix Lines 547 to 549 in e6b04a8 Edit: neotest fails on aarch64-linux, not darwin... |
Contributor
Author
Want me to gate it on aarch64, too? |
Member
|
Not sure yet, will dig deeper and then make a decision |
Member
|
Extremely strange, this patch fixes it for me diff --git a/pkgs/development/lua-modules/overrides.nix b/pkgs/development/lua-modules/overrides.nix
index 358560cfc771..a22d590ebb5e 100644
--- a/pkgs/development/lua-modules/overrides.nix
+++ b/pkgs/development/lua-modules/overrides.nix
@@ -560,7 +560,7 @@ in
export LUA_PATH="./lua/?.lua;./lua/?/init.lua;$LUA_PATH"
nvim --headless -i NONE \
--cmd "set rtp+=${vimPlugins.plenary-nvim}" \
- -c "PlenaryBustedDirectory tests/ {}"
+ -c "PlenaryBustedDirectory tests/ {sequential = true}"
runHook postCheck
'';Could you try it on darwin (don't forget to comment out |
Contributor
Author
Yep, builds fine on darwin (built on aarch64 and x86). So probably a classic case of not fully isolated test cases. Did you wanna add that commit so you get credit for the fix? Might actually resolve the sqlite issue I had locally, too... |
github-actions
bot
added
the
6.topic: lua
PerchunPak
reviewed
Sep 11, 2024
Contributor
Author
|
So the sqlite change fixed the one package. But, the others still fail during the tests. Result of 6 packages marked as broken and skipped:
3 packages failed to build:
440 packages built:
|
PerchunPak
approved these changes
Sep 11, 2024
Member
PerchunPak
left a comment
PerchunPak
left a comment
There was a problem hiding this comment.
LGTM!
Will post x86_64-linux and aarch64-linux nixpkgs-review runs soon
Member
|
Looks like plenary.nvim has some regressions. Anyway, I will look at it more closely tomorrow and will try to report to upstream. For now, just revert the update for plenary.nvim. Also, @teto, is there any particular reason why plenary.nvim is not used from |
wegank
added
the
12.approvals: 1
In the update script, there was a bug where some deprecations in `deprecated.json` were not deleted from the index file. And everything the script did was updating deprecation dates. This commit properly updates deprecated plugins and modifies dates to actual ones.
Contributor
Author
|
Result of 6 packages marked as broken and skipped:
425 packages built:
|
Contributor
Author
|
Result of 6 packages marked as broken and skipped:
4 packages failed to build:
421 packages built:
|
Contributor
Author
|
|
Contributor
|
Contributor
Author
Thanks, that makes me feel better... |
Contributor
|
Thanks for handling this @khaneliman ! |
13 tasks
ofborg
bot
added
10.rebuild-darwin: 101-500
Member
You mean, build multiple versions in parallel? Shouldn't nix sandbox fix this? It doesn't fail on master https://hydra.nixos.org/jobset/nixpkgs/trunk#tabs-jobs |
Contributor
Yes, building them sequentially works fine.
It should. The darwin sandbox does not always behave the same as the linux one. I was able to build |
17 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.