Skip to content

python{311,312}Packages: restore recurseIntoAttrs for package sets#330205

Merged
mweinelt merged 2 commits intoNixOS:masterfrom
mweinelt:recurse-into-python311-312
Jul 26, 2024
Merged

python{311,312}Packages: restore recurseIntoAttrs for package sets#330205
mweinelt merged 2 commits intoNixOS:masterfrom
mweinelt:recurse-into-python311-312

Conversation

@mweinelt
Copy link
Member

Fixes: 0213840 ("pythonPackages: move __attrsFailEvaluation to allo...")

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Fixes: 0213840 ("pythonPackages: move __attrsFailEvaluation to allo...")
Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So sorry.

@philiptaron
Copy link
Contributor

Also need to readd it to pkgs/top-level/coq-packages.nix (for coqPackages), missed this in 4640ede

Fixes: 0213840 ("pythonPackages: move __attrsFailEvaluation to allo...")
@mweinelt mweinelt merged commit 9014875 into NixOS:master Jul 26, 2024
@mweinelt mweinelt deleted the recurse-into-python311-312 branch July 26, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants