Skip to content

python312Packages.cmsis-svd: 0.4 -> 0.4-unstable-2024-01-25#330123

Merged
kirillrdy merged 1 commit intoNixOS:masterfrom
msanft:cmsis-svd/setuptools
Jul 28, 2024
Merged

python312Packages.cmsis-svd: 0.4 -> 0.4-unstable-2024-01-25#330123
kirillrdy merged 1 commit intoNixOS:masterfrom
msanft:cmsis-svd/setuptools

Conversation

@msanft
Copy link
Contributor

@msanft msanft commented Jul 26, 2024

Description of changes

Prerequisite to get python3Packages.greatfet to work again.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@msanft msanft requested a review from wegank July 26, 2024 08:57
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 26, 2024
kirillrdy
kirillrdy reviewed Jul 26, 2024
View reviewed changes
@msanft msanft force-pushed the cmsis-svd/setuptools branch from fa89bde to 2752da8 Compare July 26, 2024 09:02
@msanft msanft requested a review from kirillrdy July 26, 2024 09:02
@msanft
Copy link
Contributor Author

msanft commented Jul 26, 2024

Result of nixpkgs-review pr 330123 run on x86_64-linux 1

@kirillrdy
Copy link
Member

kirillrdy commented Jul 26, 2024

the reason you get 0 rebuilds is because commit message is wrong, it should be using python3Packages.cmsis-svd attribute

@msanft
Copy link
Contributor Author

msanft commented Jul 26, 2024

the reason you get 0 rebuilds is because commit message is wrong, it should be using python3Packages.cmsis-svd attribute

Interesting, thanks!

@msanft msanft force-pushed the cmsis-svd/setuptools branch from 2752da8 to 170fd21 Compare July 26, 2024 09:18
@msanft msanft changed the title pythonPackages.cmsis-svd: 0.4 -> 0.4-unstable-2024-01-25 python3Packages.cmsis-svd: 0.4 -> 0.4-unstable-2024-01-25 Jul 26, 2024
@msanft
Copy link
Contributor Author

msanft commented Jul 26, 2024

Result of nixpkgs-review pr 330123 run on x86_64-linux 1

@kirillrdy
Copy link
Member

kirillrdy commented Jul 26, 2024

the reason you get 0 rebuilds is because commit message is wrong, it should be using python3Packages.cmsis-svd attribute

Interesting, thanks!

ok so i am not sure why there are still no rebuilds, still investigaging, but commit message is more correct, as its what ofborg will use.

you can also use python312Packages.cmsis-svd as its currently default version of python

@msanft msanft changed the title python3Packages.cmsis-svd: 0.4 -> 0.4-unstable-2024-01-25 python312Packages.cmsis-svd: 0.4 -> 0.4-unstable-2024-01-25 Jul 26, 2024
@msanft msanft force-pushed the cmsis-svd/setuptools branch from 170fd21 to 9b05954 Compare July 26, 2024 09:30
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 26, 2024
@kirillrdy
Copy link
Member

kirillrdy commented Jul 26, 2024

ok mystery solved #330205

@msanft msanft force-pushed the cmsis-svd/setuptools branch from 9b05954 to 0b3345e Compare July 27, 2024 10:02
@msanft
Copy link
Contributor Author

msanft commented Jul 27, 2024

Result of nixpkgs-review pr 330123 run on x86_64-linux 1

4 packages built:
  • python311Packages.cmsis-svd
  • python311Packages.cmsis-svd.dist
  • python312Packages.cmsis-svd
  • python312Packages.cmsis-svd.dist

@kirillrdy kirillrdy requested a review from jollheef July 27, 2024 10:23
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 27, 2024
@msanft msanft requested a review from katexochen July 28, 2024 16:03
@kirillrdy kirillrdy merged commit c66091b into NixOS:master Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wegank wegank Awaiting requested review from wegank

@kirillrdy kirillrdy Awaiting requested review from kirillrdy

@katexochen katexochen Awaiting requested review from katexochen

1 more reviewer

@jollheef jollheef jollheef approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@msanft @kirillrdy @jollheef