Skip to content

Minimal set of changes to get FreeBSD stdenv building again#296581

Closed
rhelmot wants to merge 72 commits intoNixOS:stagingfrom
rhelmot:freebsd-minimal
Closed

Minimal set of changes to get FreeBSD stdenv building again#296581
rhelmot wants to merge 72 commits intoNixOS:stagingfrom
rhelmot:freebsd-minimal

Conversation

@rhelmot
Copy link
Contributor

@rhelmot rhelmot commented Mar 17, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
    • x86_64-freebsd
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: stdenv Standard environment 6.topic: lib The Nixpkgs function library labels Mar 17, 2024
@rhelmot rhelmot force-pushed the freebsd-minimal branch 3 times, most recently from ad0e24d to 5de86b1 Compare March 17, 2024 08:13
Mic92
Mic92 reviewed Mar 17, 2024
View reviewed changes
Mic92
Mic92 reviewed Mar 17, 2024
View reviewed changes
@rhelmot @Mic92
Update maintainers/maintainer-list.nix
4f92570 
Co-authored-by: Jörg Thalheim <Mic92@users.noreply.github.com>
Mic92
Mic92 reviewed Mar 17, 2024
View reviewed changes
Mic92
Mic92 reviewed Mar 17, 2024
View reviewed changes
Mic92
Mic92 reviewed Mar 17, 2024
View reviewed changes
Mic92
Mic92 reviewed Mar 17, 2024
View reviewed changes
Mic92
Mic92 reviewed Mar 17, 2024
View reviewed changes
Mic92
Mic92 reviewed Mar 17, 2024
View reviewed changes
Mic92
Mic92 reviewed Mar 17, 2024
View reviewed changes
Mic92
Mic92 reviewed Mar 17, 2024
View reviewed changes
Mic92
Mic92 reviewed Mar 17, 2024
View reviewed changes
Mic92
Mic92 reviewed Mar 17, 2024
View reviewed changes
Mic92
Mic92 reviewed Mar 17, 2024
View reviewed changes
Mic92
Mic92 reviewed Mar 17, 2024
View reviewed changes
@rhelmot rhelmot force-pushed the freebsd-minimal branch from 6f5d234 to 2715514 Compare May 17, 2024 18:47
Mic92
Mic92 reviewed May 18, 2024
View reviewed changes
@rhelmot rhelmot marked this pull request as draft May 18, 2024 17:17
@rhelmot
Copy link
Contributor Author

rhelmot commented May 18, 2024

Note: do not spend review cycles on this one. Everything from it was broken into one of the linked pull requests, go review those!

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label May 20, 2024
@rhelmot rhelmot mentioned this pull request May 21, 2024
Merged
14 tasks
@winterqt winterqt mentioned this pull request May 22, 2024
Closed
This was referenced May 23, 2024
Merged
Closed
Merged
Merged
Merged
This was referenced May 26, 2024
Merged
Merged
@rhelmot rhelmot closed this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mic92 Mic92 Mic92 approved these changes

@Ericson2314 Ericson2314 Ericson2314 left review comments

@artemist artemist artemist left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@RaitoBezarius RaitoBezarius Awaiting requested review from RaitoBezarius

@FRidh FRidh Awaiting requested review from FRidh

@alyssais alyssais Awaiting requested review from alyssais

@zowoq zowoq Awaiting requested review from zowoq

@winterqt winterqt Awaiting requested review from winterqt

@figsoda figsoda Awaiting requested review from figsoda

@infinisil infinisil Awaiting requested review from infinisil

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: bsd Running or building packages on BSD 6.topic: flakes The experimental Nix feature 6.topic: lib The Nixpkgs function library 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: stdenv Standard environment 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@rhelmot @SuperSandro2000 @alyssais @Ericson2314 @Mic92 @artemist @wegank